Skip to content

[18.0][MIG] website_sale_product_assortment: Migration to 18.0 - #1120

Merged
OCA-git-bot merged 14 commits into
OCA:18.0from
Tecnativa:18.0-mig-website_sale_product_assortment
Jun 1, 2026
Merged

[18.0][MIG] website_sale_product_assortment: Migration to 18.0#1120
OCA-git-bot merged 14 commits into
OCA:18.0from
Tecnativa:18.0-mig-website_sale_product_assortment

Conversation

@CarlosRoca13

@CarlosRoca13 CarlosRoca13 commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

cc @Tecnativa TT54537

This PR superseds #998 because author is not giving response

ping @pedrobaeza @pilarvargas-tecnativa

@CarlosRoca13
CarlosRoca13 force-pushed the 18.0-mig-website_sale_product_assortment branch from 9ba689e to 4389a7f Compare October 17, 2025 15:13
@pedrobaeza

pedrobaeza commented Oct 17, 2025

Copy link
Copy Markdown
Member

/ocabot migration website_sale_product_assortment

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 17, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 17, 2025
Open
46 tasks
@pilarvargas-tecnativa

pilarvargas-tecnativa commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Is #975 necessary here?

@PieterPaulussen

PieterPaulussen commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

@carlosdauden I've tested this module and found the following missing features:

  • The product domains are not respected when navigating the shop. You can test this by using a demo user and limit a product assortment to it. Log in with the demo user and then validate that the exact number of products are listed. (which does not happen)
  • The Visibility filter is also not applied correctly.

@mariancuadranetkia

mariancuadranetkia commented Feb 19, 2026

Copy link
Copy Markdown

@CarlosRoca13 can you rebase? We like to check functionality.
Thanks!

@CarlosRoca13
CarlosRoca13 force-pushed the 18.0-mig-website_sale_product_assortment branch from 4389a7f to aac5786 Compare March 2, 2026 11:08
@mariancuadranetkia

mariancuadranetkia commented Mar 3, 2026

Copy link
Copy Markdown

@CarlosRoca13 thanks for rebase!

As @PieterPaulussen commented before, visibility in website is not applied correctly. We can see assortments defined as not visible with assortment. Only add to cart button is disabled enough we have availability on website as 'avoid to show non available products':
imagen

I'm not sure if it could be because I set FURN_0097 as restricted product which is a variant of a template with more variants... If you think so, I can test with 1-1 product_template-product_product to check if is respected this visibility with different assortments
Thanks in advance!

CarlosRoca13 and others added 14 commits May 25, 2026 16:26
@CarlosRoca13
[ADD] website_sale_product_assortment: New module to use product asso…
e35e2a4 
…rtments on e-commerce
@carlosdauden @CarlosRoca13
[FIX] website_sale_product_assortment: 'set' object does not support …
ebcb2a2 
…indexing
@CarlosRoca13
[FIX] website_sale_product_assortment: Error when no variant_ids in t…
7fa8242 
…emplate
@AshishHirapara @CarlosRoca13
[IMP] website_sale_product_assortment: black, isort, prettier
a876272
@AshishHirapara @CarlosRoca13
[MIG] website_sale_product_assortment: Migration to 14.0
2a61183
@francesco-ooops @CarlosRoca13
Added translation using Weblate (Italian)
d1abb2c
@stefan-tecnativa @CarlosRoca13
[MIG] website_sale_product_assortment: Migration to 15.0
64f5b44
@mymage @CarlosRoca13
Translated using Weblate (Italian)
e3281ad 
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-15.0/e-commerce-15.0-website_sale_product_assortment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_product_assortment/it/
@Ivorra78 @CarlosRoca13
Translated using Weblate (Spanish)
17e51d1 
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-15.0/e-commerce-15.0-website_sale_product_assortment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_product_assortment/es/
@pilarvargas-tecnativa @CarlosRoca13
[MIG] website_sale_product_assortment: Migration to version 16.0
57c59ff 
TT44381
@SirAionTech @CarlosRoca13
[IMP] website_sale_product_assortment: bullet list
acba377
@PieterPaulussen @CarlosRoca13
[IMP] website_sale_product_assortment: pre-commit auto fixes
6c08ab0
@PieterPaulussen @CarlosRoca13
[MIG] website_sale_product_assortment: Migration to 18.0
c107fee
@CarlosRoca13
[FIX] website_sale_product_assortment: Products grid feature is not w…
fafab22 
…orking, recover it
@CarlosRoca13
CarlosRoca13 force-pushed the 18.0-mig-website_sale_product_assortment branch from aac5786 to fafab22 Compare May 25, 2026 14:26
@OCA-git-bot OCA-git-bot added series:18.0 mod:website_sale_product_assortment Module website_sale_product_assortment labels May 25, 2026
@CarlosRoca13

CarlosRoca13 commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Hi! I have tested and I'm not seeing the problem, when a user tries to go to a product that is hided, it will be impossible for him, just will find it when the product has multiple variants. In this case the variant is showed, but the client will be not able to purchase that product.

mariancuadranetkia
mariancuadranetkia approved these changes May 26, 2026
View reviewed changes

@mariancuadranetkia mariancuadranetkia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, LGTM
Thanks!!

@OCA-git-bot

OCA-git-bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza

pedrobaeza commented Jun 1, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1120-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit d58126d into OCA:18.0 Jun 1, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d60bd15. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 18.0-mig-website_sale_product_assortment branch June 1, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@pilarvargas-tecnativa pilarvargas-tecnativa pilarvargas-tecnativa approved these changes
@mariancuadranetkia mariancuadranetkia mariancuadranetkia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:website_sale_product_assortment Module website_sale_product_assortment ready to merge series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.