[19.0][MIG] crm_phonecall_summary_predefined: Migration to 19.0#758
Open
prayagrk wants to merge 32 commits into
Open
[19.0][MIG] crm_phonecall_summary_predefined: Migration to 19.0#758prayagrk wants to merge 32 commits into
prayagrk wants to merge 32 commits into
Conversation
This module fills the gap of phone marketing companies where phone call summaries can only belong to a limited amount of possibilities. OCA Transbot updated translations from Transifex
OCA Transbot updated translations from Transifex [UPD] Update crm_phonecall_summary_predefined.pot
[MIG] crm_phonecall_summary_predefined: Migration to 12.0. [UPD] README.rst [UPD] Update crm_phonecall_summary_predefined.pot
Currently translated at 100.0% (15 of 15 strings) Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/es/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/
Currently translated at 50.0% (8 of 16 strings) Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/de/ [UPD] README.rst
Currently translated at 100.0% (16 of 16 strings) Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/pt_BR/
Currently translated at 100.0% (16 of 16 strings) Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/hr/
Currently translated at 100.0% (16 of 16 strings) Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/it/
Currently translated at 100.0% (16 of 16 strings) Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/es/
Currently translated at 100.0% (16 of 16 strings) Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/sl/
[UPD] Update crm_phonecall_summary_predefined.pot [UPD] README.rst
Currently translated at 100.0% (16 of 16 strings) Translation: crm-13.0/crm-13.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall_summary_predefined/es_AR/
Currently translated at 100.0% (18 of 18 strings) Translation: crm-13.0/crm-13.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall_summary_predefined/pt_BR/
[UPD] Update crm_phonecall_summary_predefined.pot [UPD] README.rst
Currently translated at 100.0% (18 of 18 strings) Translation: crm-15.0/crm-15.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_phonecall_summary_predefined/it/ [UPD] README.rst
Currently translated at 100.0% (18 of 18 strings) Translation: crm-15.0/crm-15.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_phonecall_summary_predefined/es/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-15.0/crm-15.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_phonecall_summary_predefined/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-17.0/crm-17.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_phonecall_summary_predefined/
Currently translated at 88.2% (15 of 17 strings) Translation: crm-18.0/crm-18.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall_summary_predefined/sl/
Currently translated at 100.0% (17 of 17 strings) Translation: crm-18.0/crm-18.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall_summary_predefined/sl/
Currently translated at 100.0% (17 of 17 strings) Translation: crm-18.0/crm-18.0-crm_phonecall_summary_predefined Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall_summary_predefined/sl/
|
Code Review LGTM. I don't see any migration issues. Just one minor nit: the duplicated active_model key in test_wizard_default_get_non_phonecall_model could be simplified by removing the first assignment since it's immediately overridden. Otherwise, looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crm_phonecall_summary_predefined: Migration to 19.0