[OU_ADD] website_sale_product_description: rename field#5409
Open
luisDIXMIT wants to merge 1 commit into
Open
Conversation
luisDIXMIT
force-pushed
the
18.0-ou_add-website-sale_product_description
branch
2 times, most recently
from
345d33c to
35686ba
Compare
etobella
requested changes
Oct 20, 2025
| openupgrade.logged_query( | ||
| env.cr, "UPDATE product_ribbon SET text_color='' WHERE text_color IS NULL" | ||
| ) | ||
| openupgrade.logged_query( |
Member
There was a problem hiding this comment.
No, you should add here a check if the field public_description exists. Imagine that the module is not installed 😉
luisDIXMIT
force-pushed
the
18.0-ou_add-website-sale_product_description
branch
from
35686ba to
91f69f9
Compare
etobella
approved these changes
Oct 20, 2025
| env.cr, "UPDATE product_ribbon SET text_color='' WHERE text_color IS NULL" | ||
| ) | ||
| if openupgrade.column_exists(env.cr, "product_template", "public_description"): | ||
| openupgrade.logged_query( |
Member
There was a problem hiding this comment.
Add a comment to know why it is here, but yes, this is how it should be.
…escription to description_ecommerce
luisDIXMIT
force-pushed
the
18.0-ou_add-website-sale_product_description
branch
from
91f69f9 to
03edb15
Compare
hbrunn
requested changes
Oct 24, 2025
hbrunn
left a comment
hbrunn
left a comment
Member
There was a problem hiding this comment.
product.template#description_ecommerce existed in v17 already, so I don't think it should be overwritten unconditionally
Member
|
Probably that means that the migration script should be in 17, isn't it? |
Member
|
but the module that's merged in providing the field has been migrated to v17. probably that shouldn't have happened? |
Member
|
Probably... At least in my opinion, that need can be filled with the field provided by odoo 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged module website_sale_product_description into website_sale.
Renamed field public_description to description_ecommerce.