fix(ui): make BreakdownBars respect page direction (RTL/LTR)#145
Closed
fix(ui): make BreakdownBars respect page direction (RTL/LTR)#145
Conversation
Closes O2sa#129 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@mvanhorn is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
O2sa
requested changes
May 3, 2026
Owner
O2sa
left a comment
O2sa
left a comment
There was a problem hiding this comment.
The breakdown bars still not matching the page direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129.
components/breakdown-bars.tsxalready destructuresdirfromuseTranslation()but never threads it onto the rendered DOM, so the breakdown card stayed LTR even when an RTL locale (Arabic) was active. This addsdir={dir}to the root<Card>, matching the pattern already used incomponents/comparison-chart.tsx:77andcomponents/language-switcher.tsx:44.One-line diff; no other functional change.
tsc --noEmitpasses locally.