Skip to content

refactor: move I18nContextValue to types/i18n.ts#144

Merged
O2sa merged 5 commits intoO2sa:mainfrom
ayushi-wq:feat/i18n-type-refactor
May 2, 2026
Merged

refactor: move I18nContextValue to types/i18n.ts#144
O2sa merged 5 commits intoO2sa:mainfrom
ayushi-wq:feat/i18n-type-refactor

Conversation

@ayushi-wq
Copy link
Copy Markdown
Contributor

Fixes #143

Additionally, at the time of submission of this PR:

  • The referred issue is not blocked currently
  • All unittests passed after changes were made

@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026

@ayushi-wq is attempting to deploy a commit to the osama's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Thank you for the pull request! ✅

A maintainer will review this soon. Please be patient while we take a look. 🙌

Copy link
Copy Markdown
Owner

@O2sa O2sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but you should use pnpm instead of npm, you can see the contribution guide for the details: CONTRIBUTING.md.

Try to remove the package-lock.json file and i will accept this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dev-impact Ready Ready Preview, Comment May 2, 2026 5:11pm

Comment thread types/i18n.ts Outdated
@O2sa O2sa merged commit e71b496 into O2sa:main May 2, 2026
2 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Thank you, @ayushi-wq! Another great contribution merged! 🚀

We truly appreciate your continued support! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: Move I18nContextValue type definition to central types directory

2 participants