-
-
Notifications
You must be signed in to change notification settings - Fork 6
Fix: Multitouch stability during rapid system changes #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NullPointerDepressiveDisorder
merged 1 commit into
main
from
seer/fix/multitouch-stability
Feb 6, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,15 +11,18 @@ final class MultitouchManager: @unchecked Sendable { | |
| /// Delay after stopping before restarting devices during wake-from-sleep. | ||
| /// This allows the MultitouchSupport framework's internal thread (mt_ThreadedMTEntry) | ||
| /// to fully complete cleanup before we start new devices. | ||
| /// Value determined empirically: 250ms is sufficient to avoid CFRelease(NULL) crashes | ||
| /// caused by the framework accessing deallocated resources. Increased from 100ms to | ||
| /// handle rapid foreground/background toggling that can trigger multiple restart cycles. | ||
| static let restartCleanupDelay: TimeInterval = 0.25 | ||
| /// Value determined empirically: 500ms is sufficient to avoid CFRelease(NULL) crashes | ||
| /// and EXC_BREAKPOINT exceptions during rapid connectivity changes (wifi ↔ none). | ||
|
||
| /// Increased from 250ms to handle rapid connectivity toggling that triggers multiple | ||
| /// restart cycles in quick succession. | ||
| static let restartCleanupDelay: TimeInterval = 0.5 | ||
|
|
||
| /// Minimum delay between restart operations to prevent race conditions. | ||
| /// When multiple restart triggers occur in rapid succession, we debounce them | ||
| /// by waiting at least this long after the last restart completed. | ||
| static let minimumRestartInterval: TimeInterval = 0.3 | ||
| /// When multiple restart triggers occur in rapid succession (e.g., rapid connectivity | ||
| /// changes wifi ↔ none), we debounce them by waiting at least this long after the | ||
|
||
| /// last restart completed. This prevents overlapping restart attempts that can expose | ||
| /// race conditions in the MultitouchSupport framework's internal thread. | ||
| static let minimumRestartInterval: TimeInterval = 0.6 | ||
|
|
||
| // MARK: - Properties | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "wifi" should be capitalized as "Wi-Fi" for proper spelling.