refactoring as part of assignment - #133
Open
cbhakar wants to merge 4 commits into
Open
Conversation
cbhakar
commented
Oct 13, 2021
| @@ -50,9 +50,7 @@ func (agent *KlevrAgent) handShake() *common.Primary { | |||
| agent.schedulerInterval = body.Me.CallCycle | |||
|
|
|||
| if len(body.Agent.Nodes) > 0 { | |||
Author
There was a problem hiding this comment.
for loop not needed as i can be done directly
cbhakar
commented
Oct 13, 2021
| @@ -103,9 +103,8 @@ func (agent *KlevrAgent) getRemoteUpdatedTasks() []common.KlevrTask { | |||
|
|
|||
| logger.Debugf("tasks: %v", tasks) | |||
|
|
|||
Author
There was a problem hiding this comment.
for loop not needed as i can be done directly
|
In situations where alive is true, it seems like you need to constantly check buf channel. |
Author
certainly, you're correct, this is an accidental change in queue.go maybe i was just exploring and commited, I'm sorry. |
Author
|
i"m sorry i accidently closed the pull request as well. please ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.