doc: update nic/fcp percent metric docs - #4364
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Harvest’s generated metric documentation/metadata to clarify how NIC/FCP “percent” metrics should be interpreted and to include newly documented FCP read/write percent counters.
Changes:
- Add
fcp_read_percent/fcp_write_percentmetric documentation and metadata, and clarifyfcp_util_percentsemantics. - Clarify that NIC/FCP “percent” metrics are emitted as fractions in the 0–1 range (multiply by 100 for human-readable percent).
- Regenerate metrics docs (creation date bumps across multiple docs).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mcp/metadata/ontap_metrics.json | Adds/updates metric descriptions for NIC/FCP percent metrics, including 0–1 scaling notes. |
| cmd/tools/generate/counter.yaml | Updates counter descriptions and adds FCP read/write percent counters (Harvest-generated). |
| docs/ontap-metrics.md | Documents new FCP percent metrics and clarifies scaling; includes regenerated content. |
| docs/storagegrid-metrics.md | Regenerated doc header (creation date). |
| docs/eseries-metrics.md | Regenerated doc header (creation date). |
| docs/cisco-switch-metrics.md | Regenerated doc header (creation date). |
| docs/arista-switch-metrics.md | Regenerated doc header (creation date). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hardikl
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.