fix: ci issue - #4357
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the MetricAgent compute-metric behavior to avoid dropping derived metrics in single-matrix mode when a non-primary operand metric exists but has no value for a given instance (treating that missing operand as 0 instead of skipping the derived metric), and adds a regression test for the scenario.
Changes:
- Update
computeMetricsto only skip derived metric computation on missing operand values in the multi-matrix case. - Add a unit test covering single-matrix computation when optional operands are missing for an instance.
- Minor import ordering cleanup in the test file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/poller/plugin/metricagent/metric_agent.go | Changes missing-operand handling so single-matrix rules don’t skip derived metrics when an operand value is absent. |
| cmd/poller/plugin/metricagent/metric_agent_test.go | Adds a regression test ensuring missing optional operands are treated as 0 (and fixes import order). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
approved these changes
Jul 22, 2026
Hardikl
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.