Support eval mode for dynamicemb and move insert in backward to forward for use_index_dedup=True#136
Merged
Merged
Conversation
3 tasks
jiashuy
reviewed
Aug 8, 2025
jiashuy
left a comment
jiashuy
left a comment
Collaborator
There was a problem hiding this comment.
Need to develop find, to support only lookup embedding based on main branch.
Contributor
|
I've modified with the latest interface, I can refresh the commit later. |
shijieliu
force-pushed
the
fea-dynamic_eval_mode
branch
2 times, most recently
from
August 9, 2025 01:37
928b21b to
fd2810c
Compare
jiashuy
reviewed
Aug 11, 2025
jiashuy
reviewed
Aug 11, 2025
shijieliu
force-pushed
the
fea-dynamic_eval_mode
branch
from
August 11, 2025 10:06
fd2810c to
59b97bd
Compare
Collaborator
Author
|
hi @WhoisZihan could you help review this PR? |
WhoisZihan
reviewed
Aug 12, 2025
shijieliu
changed the title
Contributor
|
LGTM overall, I guess we can finish the review in later PRs. |
jiashuy
approved these changes
Aug 13, 2025
jiashuy
left a comment
jiashuy
left a comment
Collaborator
There was a problem hiding this comment.
Approved, I will rebase it in Cache&Storage refactor.
fshhr46
pushed a commit
to fshhr46/recsys-examples
that referenced
this pull request
Mar 25, 2026
…rd for use_index_dedup=True (NVIDIA#136) * Support eval mode for dynamicemb * dynamicemb support eval_initializer * refactor lookup_dense; support lookup_dense_eval * fix perf bug and update perf number for dynamicemb --------- Co-authored-by: Zihan Yang <whois.zihan.yang@gmail.com>
fshhr46
pushed a commit
to fshhr46/recsys-examples
that referenced
this pull request
Mar 25, 2026
…rd for use_index_dedup=True (NVIDIA#136) * Support eval mode for dynamicemb * dynamicemb support eval_initializer * refactor lookup_dense; support lookup_dense_eval * fix perf bug and update perf number for dynamicemb --------- Co-authored-by: Zihan Yang <whois.zihan.yang@gmail.com>
fshhr46
pushed a commit
to fshhr46/recsys-examples
that referenced
this pull request
Mar 25, 2026
…rd for use_index_dedup=True (NVIDIA#136) * Support eval mode for dynamicemb * dynamicemb support eval_initializer * refactor lookup_dense; support lookup_dense_eval * fix perf bug and update perf number for dynamicemb --------- Co-authored-by: Zihan Yang <whois.zihan.yang@gmail.com>
fshhr46
pushed a commit
to fshhr46/recsys-examples
that referenced
this pull request
Mar 25, 2026
…rd for use_index_dedup=True (NVIDIA#136) * Support eval mode for dynamicemb * dynamicemb support eval_initializer * refactor lookup_dense; support lookup_dense_eval * fix perf bug and update perf number for dynamicemb --------- Co-authored-by: Zihan Yang <whois.zihan.yang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist