allow generators.Base.generate() to take an optional param specifying generation count - #600
Merged
Conversation
Collaborator
Author
|
oh hey we should be checking if models generate the number of responses we want, and define & test what happens when they don't. cool cool cool (#601 ) |
leondz
added
architecture
17 tasks
erickgalinkin
requested changes
Apr 11, 2024
erickgalinkin
approved these changes
Apr 23, 2024
erickgalinkin
left a comment
erickgalinkin
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me!
Signed-off-by: Leon Derczynski <leonderczynski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also required clearing up some type signatures and amending
_call_modela bunch of placesWould rather
_call_modeldidn't have to take an extra param, but sometimes it cares about the number of generations. Because generator objects handle parallel requests, they're not a great place to handle state - each generation request should be atomic and self-containedLeaving in
_call_model'sgenerations_this_callparam makes for a weird situation where one might think_call_modelcan be invokes asking for many generations, where in fact this may be ignored (undef behaviour)