Example 77 add blackwell fmha bwd for MLA shape#2466
Merged
Conversation
thakkarV
reviewed
Jul 14, 2025
thakkarV
reviewed
Jul 14, 2025
Contributor
Author
|
@thakkarV Hi, I just add some new commits which fix the casual mask when IsQBegin==false, which means the Q and K are aligned at tail when seqlen_q != seqlen_kv. Please have a look. |
Contributor
|
@IonThruster @hwu36 please fwd to Richard? |
Contributor
|
@v0i0 too in case you have time to review |
Co-authored-by: Vijay Thakkar <vijaythakkar@me.com>
…pport different dim in bwd_convert
uchihatmtkinu
force-pushed
the
fmha_blackwell_bwd_mla
branch
from
July 22, 2025 03:32
d4416b8 to
b468b12
Compare
hwu36
approved these changes
Jul 24, 2025
Albresky
pushed a commit
to Albresky/cutlass
that referenced
this pull request
Oct 11, 2025
* Update examples/77_blackwell_fmha/device/fmha_device_bwd.hpp Co-authored-by: Vijay Thakkar <vijaythakkar@me.com> * bug fix & use existing value rather than pass one more argument to support different dim in bwd_convert * Fix casual mask cnt when IsQBegin==false * bug fix in casual mask backward * code sync --------- Co-authored-by: Vijay Thakkar <vijaythakkar@me.com>
guocuimi
pushed a commit
to vectorch-ai/cutlass
that referenced
this pull request
Nov 6, 2025
* Update examples/77_blackwell_fmha/device/fmha_device_bwd.hpp Co-authored-by: Vijay Thakkar <vijaythakkar@me.com> * bug fix & use existing value rather than pass one more argument to support different dim in bwd_convert * Fix casual mask cnt when IsQBegin==false * bug fix in casual mask backward * code sync --------- Co-authored-by: Vijay Thakkar <vijaythakkar@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add MLA shape($d_{qk}=192$ ,$d_{vo}=128$ ) of attention bwd kernels in example 77. Both fp8 and fp16 are supported.
Design of MLA bwd kernel
fmha_bwd_mla has several changes to handle the larger $d_{qk} size:
Examples
The bwd MLA also uses 77_blackwell_fmha_bwd_fp(type), to trigger it, using --d=192 --d_vo=128.
Performance Data