Use cmake --build instead of make -C#85
Open
jacobhinkle wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
f2a0c9a to
f13027e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On my system, Ubuntu 24.04 image with CMake 3.28.3, the cmake config defaults to the ninja generator, leading to an error in
pip install -e .because noMakefileis generated. Instead, we can use cmake to do the build as well usingcmake --build <build_dir>which will call whatever tool matches the default generator.Fixes #84
Checklist