Skip to content

Use cmake --build instead of make -C#85

Open
jacobhinkle wants to merge 1 commit intoNVIDIA:mainfrom
jacobhinkle:jh/cmake_build_generator
Open

Use cmake --build instead of make -C#85
jacobhinkle wants to merge 1 commit intoNVIDIA:mainfrom
jacobhinkle:jh/cmake_build_generator

Conversation

@jacobhinkle
Copy link
Copy Markdown

Description

On my system, Ubuntu 24.04 image with CMake 3.28.3, the cmake config defaults to the ninja generator, leading to an error in pip install -e . because no Makefile is generated. Instead, we can use cmake to do the build as well using cmake --build <build_dir> which will call whatever tool matches the default generator.

Fixes #84

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jacobhinkle jacobhinkle changed the title Jh/cmake build generator Use cmake --build instead of make -C Apr 29, 2026
@jacobhinkle jacobhinkle force-pushed the jh/cmake_build_generator branch from f2a0c9a to f13027e Compare April 29, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Source install fails when cmake defaults to Ninja generator

1 participant