Test softmax stats outputs in various permutations - #304
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesStride Stats Randomization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@cudnn-ci-bot run |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-304-e951831 |
|
These tests fail with the given changes, so apparently the underlying bug still hasn't been fully fixed: Marking this as draft again. |
Ensure that various layouts of softmax stats (and other softmax outputs) are tested, when in non-ragged mode.
Previously we didn't test this due to https://nvbugspro.nvidia.com/bug/6057616 , which apparently has already been fixed. This PR provides additional confirmation that the bug has been fixed and will help prevent it from reappearing in the future.
Summary by CodeRabbit