[cuda.compute]: Add ci matrix entry for minimal ft testing on windows by NaderAlAwar · Pull Request #9887 · NVIDIA/cccl

NaderAlAwar · 2026-07-16T00:45:15Z

closes #9648

merge first:

copy-pr-bot · 2026-07-16T00:45:18Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

NaderAlAwar · 2026-07-16T00:45:40Z

/ok to test d866731

NaderAlAwar · 2026-07-21T13:11:32Z

/ok to test c1ec0d8

coderabbitai · 2026-07-21T13:23:46Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 22705e81-615b-4d5b-8f3e-61d87f5d026d

📥 Commits

Reviewing files that changed from the base of the PR and between f86d95b and bf971dc.

📒 Files selected for processing (1)

ci/windows/build_cuda_cccl_python.ps1

📝 Walkthrough

Summary by CodeRabbit

Tests
- Expanded CUDA minimal Python CI for free-threaded runs to also cover MSVC 2022 (mirrored in nightly), while keeping the non-free-threaded minimal lane on GCC 13.
- Added/updated Windows CUDA compute minimal Python CI to run distributed pytest and, for free-threaded Python, additional stress/serialization and GIL-free validation checks.
- Standardized fail-fast error handling for CUDA build/test scripts to reliably stop on native command failures.
Documentation
- Updated free-threaded Python support docs to remove Linux-only wording and clarify validation is performed using minimal-cu12/minimal-cu13 (not cu12/cu13).

Walkthrough

Changes

Adds Windows CUDA Python minimal-test execution with free-threading validation, expands Python 3.14t CI coverage to MSVC 2022, standardizes native-command failure handling, and updates documentation for validated minimal CUDA extras.

CUDA Python minimal testing

Layer / File(s)	Summary
Shared checked-command execution `ci/windows/build_common.psm1`, `ci/windows/build_cuda_cccl_python.ps1`, `ci/windows/test_cuda_cccl_examples_python.ps1`, `ci/windows/test_cuda_cccl_headers_python.ps1`, `ci/windows/test_cuda_compute_python.ps1`	Adds exported `Invoke-Checked` and uses it for native build, upload, installation, and test commands.
Windows minimal-test execution `ci/windows/test_cuda_compute_minimal_python.ps1`	Adds validated Python-version input, CUDA wheel setup, distributed `test_no_numba.py` execution, and free-threading stress, serialization, GIL-free, and parallel-thread validation for Python 3.14t.
Free-threaded CI compiler coverage `ci/matrix.yaml`	Adds `msvc2022` alongside `gcc13` in the pull-request and nightly Python 3.14t CUDA compute minimal lanes.
Free-threading support documentation `docs/python/compute/developer_overview.rst`, `docs/python/compute/index.rst`, `docs/python/setup.rst`	Removes the Linux qualifier and identifies `minimal-cu12` and `minimal-cu13` as the validated free-threaded configurations.

Assessment against linked issues

Objective	Addressed	Explanation
Test Python 3.14 free threading on Windows [`#9648`]	✅

Out-of-scope changes

Code Change	Explanation
Shared `Invoke-Checked` adoption in CUDA build and upload flows (`ci/windows/build_cuda_cccl_python.ps1:227,285,360-368,417`)	These changes alter build, wheel merge, Docker, and artifact-upload error handling rather than adding Windows Python 3.14 free-threading tests.

Suggested reviewers: jrhemstad, gonidelis

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5bb3a2fa-8b01-449e-8bda-ab5261682b72

📥 Commits

Reviewing files that changed from the base of the PR and between 1823f19 and c1ec0d8.

📒 Files selected for processing (2)

ci/matrix.yaml
ci/windows/test_cuda_compute_minimal_python.ps1

…into add-windows-minimal-ft

NaderAlAwar · 2026-07-21T13:40:00Z

/ok to test 8a8344c

NaderAlAwar · 2026-07-21T16:31:43Z

The fix for CI is in #10049

…into add-windows-minimal-ft

NaderAlAwar · 2026-07-22T13:20:05Z

/ok to test bc2166c

NaderAlAwar · 2026-07-24T20:40:13Z

/ok to test f86d95b

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

ci/windows/build_cuda_cccl_python.ps1 (1)

1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

suggestion: Write this PowerShell file with a UTF-8 BOM; it contains non-ASCII comments, and Windows PowerShell can misdecode them without one.

Source: Linters/SAST tools

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cda7aa4b-d954-4120-a7f9-64f4328f0b06

📥 Commits

Reviewing files that changed from the base of the PR and between cb39ee8 and f86d95b.

📒 Files selected for processing (7)

ci/matrix.yaml
ci/windows/build_common.psm1
ci/windows/build_cuda_cccl_python.ps1
ci/windows/test_cuda_cccl_examples_python.ps1
ci/windows/test_cuda_cccl_headers_python.ps1
ci/windows/test_cuda_compute_minimal_python.ps1
ci/windows/test_cuda_compute_python.ps1

🚧 Files skipped from review as they are similar to previous changes (2)

ci/matrix.yaml
ci/windows/test_cuda_compute_minimal_python.ps1

NaderAlAwar · 2026-07-24T20:55:38Z

/ok to test bf971dc

github-actions · 2026-07-25T00:02:52Z

🥳 CI Workflow Results

🟩 Finished in 3h 05m: Pass: 100%/522 | Total: 9d 15h | Max: 2h 43m | Hits: 57%/1259740

See results here.

NaderAlAwar added 3 commits July 15, 2026 18:58

add pytest run parallel

6f44234

address review

ec4557e

Add minimal testing to windows

d866731

github-project-automation Bot added this to CCCL Jul 16, 2026

github-project-automation Bot moved this to Todo in CCCL Jul 16, 2026

cccl-authenticator-app Bot moved this from Todo to In Progress in CCCL Jul 16, 2026

This comment has been minimized.

Sign in to view

NaderAlAwar added 2 commits July 16, 2026 11:08

Add missing windows script

9c64ab6

Merge branch 'main' into add-windows-minimal-ft

c1ec0d8

NaderAlAwar marked this pull request as ready for review July 21, 2026 13:11

NaderAlAwar requested a review from a team as a code owner July 21, 2026 13:11

NaderAlAwar requested a review from jrhemstad July 21, 2026 13:11

cccl-authenticator-app Bot moved this from In Progress to In Review in CCCL Jul 21, 2026

coderabbitai Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread ci/matrix.yaml

Comment thread ci/windows/test_cuda_compute_minimal_python.ps1 Outdated

NaderAlAwar added 2 commits July 21, 2026 08:39

Address comments and update docs

fe9526b

Merge branch 'add-windows-minimal-ft' of github.com:NaderAlAwar/cccl …

8a8344c

…into add-windows-minimal-ft

NaderAlAwar requested a review from a team as a code owner July 21, 2026 13:39

NaderAlAwar requested a review from gonidelis July 21, 2026 13:39

NaderAlAwar mentioned this pull request Jul 21, 2026

[cuda.compute]: Fix windows race related to get nvrtc type name #10049

Merged

This comment has been minimized.

Sign in to view

Merge branch 'main' into add-windows-minimal-ft

3cda278

This comment has been minimized.

Sign in to view

NaderAlAwar added 2 commits July 22, 2026 08:16

Merge branch 'main' into add-windows-minimal-ft

87f129b

Merge branch 'add-windows-minimal-ft' of github.com:NaderAlAwar/cccl …

bc2166c

…into add-windows-minimal-ft

Jacobfaib requested a review from wmaxey July 22, 2026 13:27

This comment has been minimized.

Sign in to view

Merge branch 'main' into add-windows-minimal-ft

cb39ee8

wmaxey approved these changes Jul 24, 2026

View reviewed changes

Comment thread ci/windows/test_cuda_compute_minimal_python.ps1 Outdated

This comment has been minimized.

Sign in to view

NaderAlAwar added 3 commits July 24, 2026 15:14

Merge branch 'main' into add-windows-minimal-ft

de85a70

Pin to container

b9ce5ee

Move error checking code into common function

f86d95b

NaderAlAwar enabled auto-merge (squash) July 24, 2026 20:42

coderabbitai Bot reviewed Jul 24, 2026

View reviewed changes

address review

bf971dc

NaderAlAwar merged commit 3614b03 into NVIDIA:main Jul 25, 2026
602 checks passed

github-project-automation Bot moved this from In Review to Done in CCCL Jul 25, 2026

Uh oh!

Conversation

NaderAlAwar commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot Bot commented Jul 16, 2026

Uh oh!

NaderAlAwar commented Jul 16, 2026

Uh oh!

This comment has been minimized.

NaderAlAwar commented Jul 21, 2026

Uh oh!

coderabbitai Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Summary by CodeRabbit

Walkthrough

Changes

Assessment against linked issues

Out-of-scope changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

NaderAlAwar commented Jul 21, 2026

Uh oh!

NaderAlAwar commented Jul 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

NaderAlAwar commented Jul 22, 2026

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

NaderAlAwar commented Jul 24, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

NaderAlAwar commented Jul 24, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

🥳 CI Workflow Results

🟩 Finished in 3h 05m: Pass: 100%/522 | Total: 9d 15h | Max: 2h 43m | Hits: 57%/1259740

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NaderAlAwar commented Jul 16, 2026 •

edited

Loading

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading