fix(sandbox): apply supervisor seccomp prelude#891
Merged
johntmyers merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-891.docs.buildwithfern.com/openshell |
Collaborator
Potential follow-up: additional syscalls worth considering in the prelude denylistNot blockers for this PR — listing here so they aren't lost. The current list is thematically consistent (mount-family + kernel-module loading + kexec + bpf/perf/userfaultfd), and drawing the line cleanly around OS-119 is defensible. Highest value — historical CVE density, reachable without elevated capability
Three extra Lower priority — already gated by capability the supervisor may not hold, or DoS-leaning
|
This comment was marked as resolved.
This comment was marked as resolved.
pimlock
approved these changes
Apr 20, 2026
Collaborator
Author
|
Thanks @pimlock I've captured the feedback as a new sub-issue under OS-101. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply a narrow seccomp prelude in
openshell-sandboxbefore CLI parsing and async runtime initialization so the supervisor blocks privileged remount and kernel-surface syscalls at startup.Update the sandbox docs to reflect the new two-phase seccomp model and startup enforcement order.
Related Issue
closes OS-119
Changes
#[tokio::main]with an explicit Tokio runtime so supervisor hardening runs before Clap, logging, and runtime setupTesting
Additional validation run:
cargo fmt --allcargo run -p openshell-sandbox -- --helpmise run pre-commitwas run, but it does not pass in this local workspace for unrelated reasons:architecture/plans/567-*z3linker dependency while buildingopenshell-provertestsLinux-target verification remains incomplete locally because
x86_64-linux-gnu-gccis not installed on this machinemise run pre-commitpassesUnit tests added/updated
E2E tests added/updated (if applicable)
Checklist