Two podman driver fixes#1077
Open
cgwalters wants to merge 3 commits intoNVIDIA:mainfrom
Open
Conversation
cap_drop:ALL removes every capability in Podman's default set — including CAP_DAC_OVERRIDE, CAP_CHOWN, CAP_FOWNER, CAP_SETUID, CAP_SETGID — and the original cap_add list failed to re-add them which we need. We also don't need to add CAP_SETUID and CAP_SETGID - those are defaults. Signed-off-by: Colin Walters <walters@verbum.org>
Two bugs in the Podman e2e gateway startup:
1. Health check: curl probed /healthz on the main gRPC port, which always
returns 404 because the health router is only served on --health-port
(a separate listener, disabled by default). Allocate a second free port
and pass --health-port to the gateway; health check now probes that port.
2. SSH port: --ssh-gateway-port was not set, so the gateway always told
clients to connect SSH to port 8080 regardless of the actual port.
Explicitly pass --ssh-gateway-port ${PORT} to fix sandbox exec/SSH.
Signed-off-by: Colin Walters <walters@verbum.org>
Port 8080 is commonly in use on developer machines and CI hosts, causing
the sandbox_create_keeps_sandbox_with_forwarding test to fail with a bind
error. Probe for a free port via TcpListener::bind("127.0.0.1:0") and
release it before handing it to sandbox_create.
Assisted-by: OpenCode (claude-sonnet-4-6@default)
Signed-off-by: Colin Walters <walters@verbum.org>
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. recheck |
11 tasks
Author
|
recheck |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for the podman driver.
Related Issue
None
Changes
Fix the capability dropping, and a fix for the e2e tests.
Testing
mise run pre-commitpasses (well, almost, the binary hashing fails, but that's an existing bug I'll file separately)Checklist