Skip to content

save metadata.json & common.py on local rank 0 on each node#4893

Closed
dimapihtar wants to merge 9 commits into
NVIDIA:mainfrom
dimapihtar:ckpt_multinode_save
Closed

save metadata.json & common.py on local rank 0 on each node#4893
dimapihtar wants to merge 9 commits into
NVIDIA:mainfrom
dimapihtar:ckpt_multinode_save

Conversation

@dimapihtar

@dimapihtar dimapihtar commented May 20, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Switched metadata.json & common.py writes from "global rank 0 only" to "local rank 0 on each node". Fix for: #1531

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot

copy-pr-bot Bot commented May 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dimapihtar
dimapihtar marked this pull request as ready for review May 20, 2026 12:17
@dimapihtar
dimapihtar requested review from a team as code owners May 20, 2026 12:17
@dimapihtar dimapihtar added complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels May 20, 2026
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team May 20, 2026 12:17
@dimapihtar

Copy link
Copy Markdown
Contributor Author

/ok to test abba529

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label May 20, 2026

@asolergi-nv asolergi-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing some context, but what is the motivation for this? 3 weeks ago in #1531 this was not necessary.

Have you tested this change with >1 nodes? With this changes now in lustre we will have many ranks saving those files in the same location, so we are fixing the setup mentioned in #1531 at the cost of regressing when using lustre...

@dimapihtar

Copy link
Copy Markdown
Contributor Author

Closing this PR. Decided that fix is not relevant.

@dimapihtar dimapihtar closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants