Don't count signature position changes inside string literals

[Luis Gabriel Gomez (lggomez)]

Fixes #1682

I noticed (just after pushing my branch) that there already is an util function here that uses regexes. I didn't run any benchmarks comparing performance (assuming both methods work the same)

[Luis Gabriel Gomez (lggomez)]

Ramya Rao (@ramya-rao-a) PTAL. I have to test it a bit more but it seems to fix the bug on the reported case of strings.Replace()

[Luis Gabriel Gomez (lggomez)]

PS: this also fixes an out of bounds access here

[Luis Gabriel Gomez (lggomez)]

Well, it covers all basic cases now, what follows is the composite strings like double quotes within back-ticks and viceversa:

[Luis Gabriel Gomez (lggomez)]

Ramya Rao (@ramya-rao-a) After several adjustments I think it is ready to try, it works for most of the basic scenarios I came up with. All ci jobs failed with a seemingly unrelated npm error, so you'll have to trigger another build

The following test fails locally but I see that it also fails on my local master branch, I'm not really sure why:

  2) Go Extension Tests
base.js:240
       Test Completion Snippets For Functions:
      AssertionError: 'funcAsVariable(${1:k})' == 'funcAsVariable(${1:k string})'
      + expected - actual
      -funcAsVariable(${1:k})
      +funcAsVariable(${1:k string})
      
      at vscode.workspace.openTextDocument.then.vscode.window.showTextDocument.then.provider.provideCompletionItemsInternal.then.items (DEV/GITHUB/vscode-go/test/go.test.ts:804:13)
      at <anonymous>

[Luis Gabriel Gomez (lggomez)]

Ramya Rao (@ramya-rao-a) PTAL

I wasn't available this last month due to work but now I'm returning to my regular schedule

Also, I couldn't find out the cause of this failure but it is a local issue only

[Vlad Barosan (vladbarosan)]

Luis Gabriel Gomez (@lggomez) I hope dont mind I refactored the existing code and reused the method you mentioned

[Luis Gabriel Gomez (lggomez)]

Not at all, this issue is long overdue so the fix will be really welcome into february's release 👍

[Joel Hendrix (jhendrixMSFT)]

Looks good and works as expected :)