This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Replace ethereumjs-wallet's hdkey with ethereum-cryptography's version - #69
Merged
Conversation
adonesky1
force-pushed
the
remove-ethereumjs-wallet
branch
from
September 20, 2022 21:27
fcdd966 to
54193b8
Compare
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
adonesky1
force-pushed
the
remove-ethereumjs-wallet
branch
4 times, most recently
from
December 6, 2022 18:32
5beb43c to
160c5de
Compare
adonesky1
force-pushed
the
remove-ethereumjs-wallet
branch
from
December 6, 2022 19:08
160c5de to
0f7d4fe
Compare
adonesky1
marked this pull request as ready for review
December 6, 2022 19:15
ethereumjs-wallet's hdkey with ethereum-cryptography's version
Gudahtt
reviewed
Dec 6, 2022
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
reviewed
Dec 7, 2022
adonesky1
force-pushed
the
remove-ethereumjs-wallet
branch
from
December 7, 2022 21:22
e937bf2 to
dec8e7c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
ethereumjs-walletimplementation ofhdkeywith one fromethereum-cryptographyand adapts accordingly.This is part of a broader effort to remove
ethereumjs-walletfrom our dependency graph for the purpose of reducing overall bundle size.ethereumjs-walletis heavier and less well maintained than ethereum-cryptography/hdkey.