Feature/vfb 215 Feature/vfb 217 Term info improvements / alerts issue#184
Merged
Conversation
…der component with a confirmation modal
Feature/vfb 217
Salam-Dalloul
changed the title
ddelpiano
requested changes
Aug 26, 2025
ddelpiano
left a comment
ddelpiano
left a comment
Member
There was a problem hiding this comment.
@Salam-Dalloul only one minor comment, I can see that the Name property is redundant between general info and metadata, what we show in general info should not appear also in metadata. Other than that, great solution. Thanks!
| <Typography>Metadata</Typography> | ||
| </AccordionSummary> | ||
| <AccordionDetails> | ||
| <GeneralInformation data={termInfoData} classes={classes} showMetadataOnly={true} /> |
Member
There was a problem hiding this comment.
nice solution for the flag usage showMetadataOnly :-) 👍🏽
ddelpiano
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.