Rename meshes for benefit of lfric2lfric - #386
Open
cjohnson-pi wants to merge 41 commits into
Open
Conversation
github-actions
Bot
added
the
cla-required
28 tasks
28 tasks
github-actions
Bot
removed
the
cla-required
cjohnson-pi
marked this pull request as ready for review
July 20, 2026 08:50
cjohnson-pi
requested review from
a team and
Ricky Wong (mo-rickywong)
as code owners
July 20, 2026 08:50
Ricky Wong (mo-rickywong)
requested changes
Jul 20, 2026
Ricky Wong (mo-rickywong)
left a comment
Ricky Wong (mo-rickywong)
left a comment
Contributor
There was a problem hiding this comment.
Sorry, though going to have to shoot this one down for several reasons:
- Lfric2Lfric is overstepping it mark in this change. These changes are only for the benefit lfric2lfric and impose assumptions on other apps about their naming / configuration choices.
- Names of meshes would ideally be determined be determined by the application they are for, i.e. LFRic2LFRic, however, in this case, the proposed naming convention is being imposed everywhere. This is a result of all applications just 'using' the
mesh appin rose stem to generate their meshes. I don't see anything wrong with having an lfricinputs mesh generation app. Then it can call it's meshes whatever it likes. The upgrade macros would have to distinguish what the app it was working on was. James bruten might be able to help on that. - The current mesh names were a early placeholders (in hindsight a poor choice), not meant long term. Ideally if the mesh name is to encode any information (rather than be just a label) it should only be about the mesh, not about what/where it is to be used.
Contributor
There was a problem hiding this comment.
This file will change all the names of the meshes in mesh_tools test-suite. The mesh-tools test suite has nothing to do with the mesh names used by lfric2lfric and shouldn't know anything about it or multigrid levels.
Please do not apply this macro to mesh tools
Contributor
There was a problem hiding this comment.
Driver settings shouldn't have any knowledge of multigrid.
Contributor
There was a problem hiding this comment.
Shouldn't have info relating to multigrid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Ricky Wong (@mo-rickywong)
Rename the meshes using an upgrade macro so that global meshes are: l0_cubedsphere, l1_cubedsphere, l2_cubedsphere and regional meshes are l0_planar, l1_planar, l2_planar. (i.e. the same name as the mesh generator and partitioner) - and with the different levels (with the l0 first so that they are easily seen when viewing the mesh with ncview, and removing any reference to primary or dynamics meshes - they are all just meshes of different levels).
This will enable lfric2lfric to regrid from global to regional in the rose-stem test-suite. Currently both the global and regional meshes are named the same thing (dynamics), which causes problems for lfric2lfric - which requires the meshes to have different names.
In addition, as the coarse-level meshes are also not only used for multigrid, it is better to rename them to a more general purpose name.
MetOffice/lfric_apps#551
blocks MetOffice/lfric_apps#530
Code Quality Checklist
Testing
trac.log
Run by first applying (from the components directory)
$UMDIR/SimSys_Scripts/lfric_macros/apply_macros.py vn3.2_t386 --core=.. --apps='/home/users/christine.johnson/git/lfric_apps'Test Suite Results - lfric_core - rename_meshes_core/run13
Suite Information
Task Information
❌ failed tasks - 90
⌛ waiting tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review