Add Jedi string method to datetime - #693
Open
DanStoneMO wants to merge 11 commits into
Open
Conversation
DanStoneMO
requested review from
Benjamin Went (MetBenjaminWent),
James Bruten (james-bruten-mo),
mo-marqh and
Thomas Bendall (tommbendall)
August 4, 2026 11:24
DanStoneMO
requested review from
a team,
Matt Shin (matthewrmshin) and
Steven Sandbach (ss421)
as code owners
August 4, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: mo-lucy-gordon
This is a small PR adding a new method to the datetime object, allowing it to be written as a ISO datetime string compatible with JEDI systems. The process of converting between LFRic and JEDI compatible datetime strings is currently hard-coded in lfric-jedi, which would be bad for maintainability down the line.
The new method is largely a copy of the current
to_stringone, just adjusting the characters used in the output string.linked PRs
Code Quality Checklist
Testing
Test results, via mo-bundle's
mobbaltopt: https://cylchub/services/cylc-review/taskjobs/daniel.stone/?suite=mob-jedi-time-convert-mobbalt-2Code Review