Rename and reorganise lfric2lfric tasks - #665
Conversation
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
|
Hi Christine - thanks for the table, it's very useful. My main objection is that you're moving a lot of cpu-heavy jobs into developer because the cpu-light equivalent jobs have been removed - developer is run a lot as the default test suite so it's best that most cpu-heavy jobs stay in extra. When they were first added to the test suite I put the limitation that 2 multi-cpu jobs would be allowed in the developer group (preferentially 1, but 2 if there was a good argument for the second) - given that was only last release cycle, I'd rather we keep to that. Also, if we could keep one of the non-oasis 1cpu jobs (one with a multi-cpu equivalent, so For similar reason as my first point, no reason to move I'm not sure about removing the 4cpu/6cpu parts of the name - I know it's simpler, but I'm not sure that it isn't more helpful to keep them. Thoughts? |
Thanks for looking at this so quickly. My thoughts... I'm not sure that I would describe these jobs as particularly cpu-heavy. e.g. Compared to https://github.com/MetOffice/lfric_apps/blob/main/rose-stem/site/common/lfric_atm/tasks_lfric_atm.cylc where I think 6cpu might be the minimum. I think its important that we keep the multiple mpi jobs in developer to just make sure they keep working. Yes I can add a non-oasis 1cpu job. I keep comparing with the lfric_atm tasks (as thats what I'm used to I suppose). These don't have the computational details in the name (unless it is specifically a performance related job). I would prefer to keep the task names consistent - so that its easy to compare. And I don't think we want to be adding the number of mpi to all of the tasks. e.g. the c896 to ukv tasks. And then the following vertical interpolation tasks... What if you needed to change the number of mpi? The task would still be doing the same job. So you shouldn't need to have to change the task name too (unless its specifically designed for monitoring performance). |
PR Summary
Reorganise the lfric2lfric testsuite (removing the redundant tests and moving some to the extra group).
Rename the lfric2lfric task names to the format
regrid_method-source-destination- for easier comparison (especially to prepare for new tasks to be added in the future).Sci/Tech Reviewer: Lottie Turner (@mo-lottieturner)
Code Reviewer: Harry Shepherd (@harry-shepherd)
split from #530
blocked by #655
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - rename_tasks/run3
Suite Information
Task Information
✅ succeeded tasks - 1196
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review