Skip to content

Add GPU annotations to subroutines called from kernels - #645

Open
Sergi Siso (sergisiso) wants to merge 1 commit into
MetOffice:mainfrom
stfc:add_gpu_annotations
Open

Add GPU annotations to subroutines called from kernels#645
Sergi Siso (sergisiso) wants to merge 1 commit into
MetOffice:mainfrom
stfc:add_gpu_annotations

Conversation

@sergisiso

@sergisiso Sergi Siso (sergisiso) commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Oakley Brunt (@oakleybrunt)

This PR has the same goal as MetOffice/lfric_core#431, to increase the coverage of LFRic code that can be offloaded to GPUs by annotating subroutines that are called from LFRic kernels but are not directly exposed to psyclone and therefore cannot be annotated automatically.

The two PRs can be merged independently, and the directives can be removed once the new build system and necessary functionality in psyclone has been added. But until then, this is the easiest practical solution to progress the work of the GIG (GPU working group).

The directives will be ignored by any compiler not targeting GPU devices.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My confusion here is why the annotations are only added to some routines and not others? For instance ffsl_flux_xy_kernel_mod.F90 is just one of several that do similar but slightly different things -- I'd expect you'd need to change all of the ffsl_flux_xy_*_kernel_mod.F90 files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants