Use consistent PSyclone config for building adjoint_tests

[DrTVockerodtMO]

PR Summary

Sci/Tech Reviewer: Josh Colclough (@mo-joshuacolclough)
Code Reviewer: Iva Kavcic (@TeranIvy)

Fix to make the adjoint_tests application export its custom PSyclone config as opposed to explicitly passing it into the import scripts. This is mainly to make local parallel runs of the adjoint_tests application work, which is a prerequisite for a fully fledged parallel adjoint_tests run on the test-suite.

We found that using the current Makefile caused some of the generated PSy layer to use the default PSyclone config, and others used the custom adjoint_tests PSyclone config. This causes some PSy layer code to iterate into halos/annexed dofs which when using the adjoint_tests application causes floating point errors during parallel runs. The new Makefile ensures the configuration is consistent and the floating point errors diminish.

Note that I could have also ammended some of the logic for the adjoint import.mk script, but since we are moving away from live building with PSyAd (see #330 ) I opted not to change this at this time.

• fixes Adjoint tests mixes PSyclone configs #297

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - adjt_psyclone_config_fix/run1

Suite Information

Item	Value
Suite Name	adjt_psyclone_config_fix/run1
Suite User	terence.vockerodt
Workflow Start	2026-03-05T14:06:23
Groups Run	developer

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.03.1	True
jules	MetOffice/jules@2026.03.1	True
lfric_apps	DrTVockerodtMO/lfric_apps@adjt_psyclone_config_fix	False
lfric_core	MetOffice/lfric_core@2026.03.1	True
moci	MetOffice/moci@2026.03.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@2026.03.1	True
socrates	MetOffice/socrates@2026.03.1	True
socrates-spectral	MetOffice/socrates-spectral@2026.03.1	True
ukca	MetOffice/ukca@2026.03.1	True

Task Information

✅ succeeded tasks - 1164

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[Josh Colclough (mo-joshuacolclough)]

Thank you for the update DrTVockerodtMO. Glad the multi-PE adjoint_tests is working now. Passes Sci/Tech review.

[Iva Kavcic (TeranIvy)]

Code review

Checked out the updated version of the fork and ran the all group test suite on Az Spice and EX. All green.

The code changes are clear, well-justified and follow LFRic development practices.

Approved and proceeding to merge.