Swap apps to use to config_loader_mod instead of configuration_mod - #239
Conversation
|
This change does alter some jedi files, a JEDI PR may be required |
Steven Sandbach (ss421)
left a comment
There was a problem hiding this comment.
The change here does not appear to effect applications and is used by integration and unit tests only. We should not be impacted by this.
svadams (svadams)
left a comment
There was a problem hiding this comment.
Straightforward changes that look fine to me. Approving for merge
|
Have brought the PR up to head to resolve the conflicts and updated the trac.log after retesting. Should be good to go. |
mo-cjsmith
left a comment
There was a problem hiding this comment.
All changes made keeping the code layout clean. Code owner approves.
svadams (svadams)
left a comment
There was a problem hiding this comment.
Changes look fine - approving for merge
Ricky Wong (mo-rickywong)
left a comment
There was a problem hiding this comment.
Just a comment to retrigger the checks
svadams (svadams)
left a comment
There was a problem hiding this comment.
All good to go - approving for merge
PR Summary
Sci/Tech Reviewer: N/A technical clean-up, straight replace on lots of files
Code Reviewer: svadams (@svadams)
Code Quality Checklist
Testing
Test Suite Results - lfric_apps - SwapToConfigLoader/run1
Suite Information
Task Information
✅ succeeded tasks - 1168
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review