Skip to content

Swap apps to use to config_loader_mod instead of configuration_mod - #239

Merged
svadams (svadams) merged 11 commits into
MetOffice:mainfrom
mo-rickywong:SwapToConfigLoader
Mar 9, 2026
Merged

Swap apps to use to config_loader_mod instead of configuration_mod#239
svadams (svadams) merged 11 commits into
MetOffice:mainfrom
mo-rickywong:SwapToConfigLoader

Conversation

@mo-rickywong

@mo-rickywong Ricky Wong (mo-rickywong) commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Sci/Tech Reviewer: N/A technical clean-up, straight replace on lots of files
Code Reviewer: svadams (@svadams)

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

Test Suite Results - lfric_apps - SwapToConfigLoader/run1

Suite Information

Item Value
Suite Name SwapToConfigLoader/run1
Suite User ricky.wong
Workflow Start 2026-02-25T09:46:34
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2025.12.1 True
jules MetOffice/jules@69aaf4d True
lfric_apps MetOffice/lfric_apps@SwapToConfigLoader False
lfric_core MetOffice/lfric_core@2ed3e79 True
moci MetOffice/moci@2025.12.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True
socrates MetOffice/socrates@2025.12.1 True
socrates-spectral MetOffice/socrates-spectral@2025.12.1 True
ukca MetOffice/ukca@2025.12.1 True

Task Information

✅ succeeded tasks - 1168

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Feb 11, 2026
@mo-rickywong

Copy link
Copy Markdown
Contributor Author

This change does alter some jedi files, a JEDI PR may be required

@ss421 Steven Sandbach (ss421) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here does not appear to effect applications and is used by integration and unit tests only. We should not be impacted by this.

@svadams svadams (svadams) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward changes that look fine to me. Approving for merge

@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Feb 25, 2026
@mo-rickywong

Copy link
Copy Markdown
Contributor Author

Have brought the PR up to head to resolve the conflicts and updated the trac.log after retesting. Should be good to go.

@mo-cjsmith mo-cjsmith left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes made keeping the code layout clean. Code owner approves.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A straightforward change.

@mo-rickywong Ricky Wong (mo-rickywong) added this to the Summer 2026 milestone Mar 5, 2026

@svadams svadams (svadams) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine - approving for merge

@svadams
svadams (svadams) requested a review from a team as a code owner March 9, 2026 08:54
@github-actions github-actions Bot added cla-modified The CLA has been modified as part of this PR - added by GA and removed cla-signed The CLA has been signed as part of this PR - added by GA labels Mar 9, 2026
@github-actions github-actions Bot removed the cla-modified The CLA has been modified as part of this PR - added by GA label Mar 9, 2026

@mo-rickywong Ricky Wong (mo-rickywong) left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to retrigger the checks

@svadams svadams (svadams) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to go - approving for merge

@svadams
svadams (svadams) merged commit e15c026 into MetOffice:main Mar 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants