Skip to content

custom field class that filters whitespaces#78

Merged
varmar05 merged 2 commits into
developfrom
trailing_spaces_check_#862jv6teu
May 24, 2023
Merged

custom field class that filters whitespaces#78
varmar05 merged 2 commits into
developfrom
trailing_spaces_check_#862jv6teu

Conversation

@harminius
Copy link
Copy Markdown
Contributor

@harminius harminius commented May 23, 2023

CU: https://app.clickup.com/t/862jv6teu

Change:

when logging in, server removes trailing spaces from username (autocomplete on mobiles added invisible space which lead to login failures)

Custom class for text fields was created and used at any place we want to remove leading and trailing spaces

In following user inputs there is already check for trailing spaces and they do not use forms:

  • create workspace invitation
  • add project
  • clone project

@harminius harminius requested a review from varmar05 May 23, 2023 21:19
Comment thread server/mergin/auth/forms.py Outdated
@varmar05 varmar05 merged commit ef40855 into develop May 24, 2023
@MarcelGeo MarcelGeo deleted the trailing_spaces_check_#862jv6teu branch June 5, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants