Skip to content

Allow share project parameter and check GLOBAL_ variables#199

Merged
MarcelGeo merged 5 commits into
developfrom
feature-allow-share
Mar 19, 2024
Merged

Allow share project parameter and check GLOBAL_ variables#199
MarcelGeo merged 5 commits into
developfrom
feature-allow-share

Conversation

@MarcelGeo
Copy link
Copy Markdown
Collaborator

@MarcelGeo MarcelGeo commented Mar 19, 2024

Details

Ticket: https://github.com/MerginMaps/server-private/issues/2220

  • Make sharing buttons visibility configurable in collaborators tab (allowShare: true props to collaborators)
  • If there is one of GLOBAL_* variable true, we will hide share project button.

GLOBAL_READ is enabled:

image

There is no GLOBAL_READ/WRITE/ADMIN

image

🌹 Minor design fixes:

  • enh: Laptops - change break point for sidebar overlay to 1200px

@MarcelGeo MarcelGeo requested a review from varmar05 March 19, 2024 10:34
Comment thread server/application.py
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8343383189

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.023%

Totals Coverage Status
Change from base Build 8323711980: 0.0%
Covered Lines: 5616
Relevant Lines: 5973

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit 768d490 into develop Mar 19, 2024
@MarcelGeo MarcelGeo deleted the feature-allow-share branch March 19, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants