Skip to content

Keep objects referenced in database#184

Merged
MarcelGeo merged 12 commits into
developfrom
better_tracking
Mar 6, 2024
Merged

Keep objects referenced in database#184
MarcelGeo merged 12 commits into
developfrom
better_tracking

Conversation

@varmar05
Copy link
Copy Markdown
Collaborator

Summary:

  • stop removing project
  • keep resolved access requests
  • migrate registration_date column to user table
  • use user_id in login history
  • stop removing users from db
  • use user.id in project.removed_by

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8154988624

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.07%) to 93.958%

Files with Coverage Reduction New Missed Lines %
server/server/mergin/sync/db_events.py 1 90.91%
server/server/mergin/auth/app.py 2 97.5%
server/server/mergin/sync/workspace.py 2 98.29%
server/server/mergin/tests/test_utils.py 2 98.77%
server/server/mergin/auth/models.py 3 97.06%
server/server/mergin/sync/models.py 7 96.64%
server/server/mergin/sync/permissions.py 12 89.63%
Totals Coverage Status
Change from base Build 8061929893: 0.07%
Covered Lines: 5567
Relevant Lines: 5925

💛 - Coveralls

@MarcelGeo MarcelGeo marked this pull request as draft March 4, 2024 08:09
@varmar05 varmar05 changed the title Draft:Keep objects referenced in database Keep objects referenced in database Mar 4, 2024
@varmar05 varmar05 marked this pull request as ready for review March 4, 2024 13:27
@varmar05 varmar05 requested a review from luxusko March 4, 2024 13:27
@varmar05
Copy link
Copy Markdown
Collaborator Author

varmar05 commented Mar 4, 2024

@MarcelGeo could you please verify this does not have impact on frontend?

Copy link
Copy Markdown
Collaborator

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, schemas are tansparent with .yml . Approve

@MarcelGeo MarcelGeo merged commit 5a4382a into develop Mar 6, 2024
@MarcelGeo MarcelGeo deleted the better_tracking branch March 6, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants