Skip to content

Get /app/project/{project_id}/access#178

Merged
MarcelGeo merged 2 commits into
develop-redesignfrom
project-access
Feb 20, 2024
Merged

Get /app/project/{project_id}/access#178
MarcelGeo merged 2 commits into
develop-redesignfrom
project-access

Conversation

@luxusko
Copy link
Copy Markdown
Contributor

@luxusko luxusko commented Feb 19, 2024

Resolves #138

@luxusko luxusko requested a review from varmar05 February 19, 2024 09:32
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 19, 2024

Pull Request Test Coverage Report for Build 7970841009

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.799%

Totals Coverage Status
Change from base Build 7959202189: 0.001%
Covered Lines: 5476
Relevant Lines: 5838

💛 - Coveralls

@MarcelGeo
Copy link
Copy Markdown
Collaborator

@luxusko I don't see tests for new endpoint.

@MarcelGeo MarcelGeo changed the base branch from develop to develop-redesign February 19, 2024 12:02
@MarcelGeo MarcelGeo changed the base branch from develop-redesign to develop February 19, 2024 12:05
@MarcelGeo MarcelGeo changed the base branch from develop to develop-redesign February 19, 2024 12:05
@MarcelGeo MarcelGeo requested review from MarcelGeo and harminius and removed request for varmar05 February 19, 2024 13:52
Comment thread server/mergin/sync/private_api_controller.py Outdated
Copy link
Copy Markdown
Contributor

@harminius harminius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with MarceGeo.

@MarcelGeo
Copy link
Copy Markdown
Collaborator

Logic: @luxusko , agreed with @varmar05

in case of GLOBAL_WRITE - everybody with reader 🔽 in project.access will be writer 🔼 , everybody with owner in project.access will be owner (NOT WRITER)

Copy link
Copy Markdown
Collaborator

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now :)

@MarcelGeo MarcelGeo merged commit 672620c into develop-redesign Feb 20, 2024
@MarcelGeo MarcelGeo deleted the project-access branch March 14, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants