Skip to content

migration and table definition#174

Merged
MarcelGeo merged 3 commits into
developfrom
registration_date_not_null
Feb 15, 2024
Merged

migration and table definition#174
MarcelGeo merged 3 commits into
developfrom
registration_date_not_null

Conversation

@harminius
Copy link
Copy Markdown
Contributor

Task 147

Define table in models and migration script.

@harminius harminius requested a review from luxusko February 13, 2024 11:28
@harminius harminius self-assigned this Feb 13, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 13, 2024

Pull Request Test Coverage Report for Build 7899110465

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.798%

Totals Coverage Status
Change from base Build 7738461344: 0.0%
Covered Lines: 5475
Relevant Lines: 5837

💛 - Coveralls

@harminius
Copy link
Copy Markdown
Contributor Author

There are 35 users with empty registration_date on dev server -> data migration included

@harminius harminius force-pushed the registration_date_not_null branch from f5cbfd9 to f92953d Compare February 13, 2024 13:59
@MarcelGeo
Copy link
Copy Markdown
Collaborator

Ok, we can merge this - @varmar05 reviewed it :)

@MarcelGeo MarcelGeo self-requested a review February 15, 2024 11:50
Copy link
Copy Markdown
Collaborator

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, similar PR as in private repo.

@MarcelGeo MarcelGeo merged commit 68f8402 into develop Feb 15, 2024
@MarcelGeo MarcelGeo deleted the registration_date_not_null branch February 15, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants