Skip to content

Redesign versions#145

Merged
MarcelGeo merged 7 commits into
develop-redesignfrom
redesign-versions
Dec 21, 2023
Merged

Redesign versions#145
MarcelGeo merged 7 commits into
develop-redesignfrom
redesign-versions

Conversation

@MarcelGeo
Copy link
Copy Markdown
Collaborator

@MarcelGeo MarcelGeo commented Dec 20, 2023 •
edited
Loading

Description

Scope: versions

image

  • Version detail sidebar

image

  • version table primevue
  • all version changsets tables to primevue

image

  • breacrumps component to alpha with router configuration in beforeEnter for /projects paths
  • sidebar active class updates based on figma

🆙 Refactor:

  • Implemented enums based on modules. When adding new view to the modules/project/views directory, it's recommended to create corresponding route names for this view. These route names can be used for routing purposes within the library or in other applications.

❗

  • router updates for breadcrumps

@MarcelGeo
Added:
1279f1b 
- version detail sidebar (not view)
- File detail version view to primevue
- small design updates for upload panel

Fix:
- row click for whole row in versions
- duplicate rendering for <router-view> in Project detail

Router:
- change router for version detail to query with version_id
@MarcelGeo
Added:
72f8492 
- alpha version of breadcrumps with configuration in router
@MarcelGeo
Return in reduce instead value
402c7f2
@MarcelGeo
cleanup console log
3de6b7a
@MarcelGeo MarcelGeo requested a review from varmar05 December 20, 2023 14:28
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 20, 2023

Pull Request Test Coverage Report for Build 7276779870

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.798%
Totals Coverage Status
Change from base Build 7250472719: 0.0%
Covered Lines: 5475
Relevant Lines: 5837
💛 - Coveralls

varmar05
varmar05 reviewed Dec 20, 2023
View reviewed changes
Comment thread web-app/packages/lib/src/modules/project/views/ProjectVersionsViewTemplate.vue Outdated
Comment thread web-app/packages/app/src/router.ts
Comment thread web-app/packages/lib/src/modules/layout/components/SideBarTemplate.vue Outdated
@MarcelGeo
Design:
81acef5 
- adjust sizing in Sidebar items
Refactor:
- typo newest
- added chnagsetssuccessummaryitem type to changesets table
Added:
- enum for route names based on module
@MarcelGeo
Eslint fixes
488177b
@MarcelGeo MarcelGeo merged commit eb4fd73 into develop-redesign Dec 21, 2023
@MarcelGeo MarcelGeo deleted the redesign-versions branch December 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varmar05 varmar05 varmar05 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcelGeo @coveralls @varmar05