Skip to content

Fix project download#127

Merged
varmar05 merged 2 commits into
masterfrom
fix_project_download
Nov 2, 2023
Merged

Fix project download#127
varmar05 merged 2 commits into
masterfrom
fix_project_download

Conversation

@varmar05
Copy link
Copy Markdown
Collaborator

This PR mitigates risk of performance penalty for file download:

  • do not load project.files from db if not needed
  • in download endpoint use db query to fetch file location instead of filtering in app

project files are rarely used compared to general usage of ORM Project, their load is deferred to avoid db performance issues
@varmar05 varmar05 changed the base branch from master to develop October 31, 2023 11:57
@varmar05 varmar05 changed the base branch from develop to master October 31, 2023 11:58
Copy link
Copy Markdown

@mostlyAtNight mostlyAtNight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you

Copy link
Copy Markdown
Contributor

@luxusko luxusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varmar05 varmar05 merged commit d737d2b into master Nov 2, 2023
@MarcelGeo MarcelGeo deleted the fix_project_download branch January 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants