Skip to content

send uuid in HTTP request#3386

Merged
PeterPetrik merged 2 commits into
masterfrom
uuid
Apr 29, 2024
Merged

send uuid in HTTP request#3386
PeterPetrik merged 2 commits into
masterfrom
uuid

Conversation

@PeterPetrik
Copy link
Copy Markdown
Contributor

@PeterPetrik PeterPetrik commented Apr 26, 2024

Add GUID to each HTTP request and also show it in the diagnosis log. GUID is generated on first run or the app.
We use X-Device-Id with uuid as custom header

@PeterPetrik PeterPetrik requested a review from tomasMizera April 26, 2024 05:45
@PeterPetrik PeterPetrik changed the title send uuid as user-agent send uuid in HTTP request Apr 26, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2024

Pull Request Test Coverage Report for Build 8875858600

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 380 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 60.053%

Files with Coverage Reduction New Missed Lines %
input/app/projectsmodel.cpp 1 69.17%
input/core/merginuserinfo.cpp 3 72.99%
input/app/inputhelp.cpp 15 36.36%
input/core/coreutils.cpp 19 86.39%
input/app/appsettings.cpp 34 72.32%
input/app/main.cpp 58 32.75%
input/core/merginapi.cpp 250 78.49%
Totals Coverage Status
Change from base Build 8843206479: 0.03%
Covered Lines: 7658
Relevant Lines: 12752

💛 - Coveralls

@tomasMizera
Copy link
Copy Markdown
Collaborator

The implementation looks good, let's see where to add it

@mostlyAtNight
Copy link
Copy Markdown
Contributor

Hi @PeterPetrik ,

Regarding how to send it, I would also be fine with it going in its own header, we should be able to accomodate that in the backend. This SE page may be useful for how to name a new one if we cannot find something appropriate to put it into.

Re the implementation itself, I have a question. I assume the UUID is automatically generated when the app is installed - is it subsequently readable and editable by the user? If so, I'm not sure this would be wise and I would instead opt for it to be stored in scoped storage or similar so it's protected from editing/cloning.

@PeterPetrik
Copy link
Copy Markdown
Contributor Author

PeterPetrik commented Apr 26, 2024

Looks like non standart headers might be blocked by firewall, what name you suggest?

Re implementation, only way how to reset it for user easily is to really remove the app completely and install from scratch.

@PeterPetrik
Copy link
Copy Markdown
Contributor Author

@varmar05 can you please secure server implementation? thanks

@PeterPetrik PeterPetrik merged commit 8b9070f into master Apr 29, 2024
@PeterPetrik PeterPetrik deleted the uuid branch April 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants