Skip to content

catch not known attributes in ClearAttributes and SetAttributes - #608

Merged
rocky merged 1 commit into
masterfrom
fix_Set_and_Clear_Attributes
Nov 11, 2022
Merged

catch not known attributes in ClearAttributes and SetAttributes#608
rocky merged 1 commit into
masterfrom
fix_Set_and_Clear_Attributes

Conversation

@mmatera

@mmatera mmatera commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

@rocky, please before merging #607, add this patch, to a bug that came up trying to load FeynCalc

@rocky

rocky commented Nov 11, 2022

Copy link
Copy Markdown
Member

@mmatera ok - after this passes CI let's merge and I will rebase off of this.

@rocky

rocky commented Nov 11, 2022

Copy link
Copy Markdown
Member

@mmatera If you have it, what is the exact error that occurs in FeynCalc?

@rocky

rocky commented Nov 11, 2022

Copy link
Copy Markdown
Member

This PR would suggest that Feyncalc has a bug which is hard to believe. So what changed in Mathematica?

@mmatera

mmatera commented Nov 11, 2022

Copy link
Copy Markdown
Contributor Author

@mmatera If you have it, what is the exact error that occurs in FeynCalc?

FeynCalc has a typo, that tries to Clear an attribute that do not exist. This patch just catch the exception.

Regarding the bug, it just tries to set ReadProtected attribute to some symbols, but there is a typo (something like ReadProtetced), that in WMA does not have any consequence, but here kills the kernel.

@rocky
rocky marked this pull request as ready for review November 11, 2022 13:03
@rocky
rocky merged commit 8a86511 into master Nov 11, 2022
@rocky
rocky deleted the fix_Set_and_Clear_Attributes branch November 11, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants