Don't hardcode unicode-symbols - #1673
Merged
rocky merged 2 commits intoFeb 3, 2026
Merged
Conversation
Also op-tables.json -> character-tables.json since that's what it is.
mmatera
reviewed
Feb 3, 2026
| sup_string = self.superindex.get_string_value() | ||
| # Handle derivatives | ||
| if sup_string == "\u2032": | ||
| if sup_string == named_characters["LeftDoubleBracket"]: |
Contributor
There was a problem hiding this comment.
This is not "\[LeftDoubleBracket]" but "\[Prime]" (the derivative, see comment above)
mmatera
reviewed
Feb 3, 2026
| ( | ||
| String("\u301A"), | ||
| String("\u301B"), | ||
| String(named_characters["LeftDoubleBracket"]), |
Contributor
There was a problem hiding this comment.
This makes a lot of sense, thanks!
mmatera
reviewed
Feb 3, 2026
| if sup_string == named_characters["LeftDoubleBracket"]: | ||
| return "%s'" % tex1 | ||
| if sup_string == "\u2032\u2032": | ||
| if sup_string == named_characters["LeftDoubleBracket"] * 2: |
Contributor
There was a problem hiding this comment.
This is This is not "\[LeftDoubleBracket]\[LeftDoubleBracket]" but "\[Prime]\[Prime]" (the derivative, see comment above)
Member
Author
There was a problem hiding this comment.
@mmatera, thanks for the correction. Is this correct now?
mmatera
approved these changes
Feb 3, 2026
mmatera
left a comment
mmatera
left a comment
Contributor
There was a problem hiding this comment.
Besides the two wrong names, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't hardcode unicode-symbols. Also, op-tables.json -> character-tables.json since that's what it is.