Scoped feature flags 1/3: scope declaration and per-replica override plumbing#37079
Merged
antiguru merged 1 commit intoJun 17, 2026
Merged
Conversation
This was referenced Jun 16, 2026
DAlperin
reviewed
Jun 16, 2026
DAlperin
reviewed
Jun 16, 2026
aljoscha
reviewed
Jun 17, 2026
aljoscha
left a comment
aljoscha
left a comment
Contributor
There was a problem hiding this comment.
looks good! I did have some inline comments that I'm sure the ai can easily clean up
The additive foundation for scoped feature flags, with no behavior change on its own. * `ParameterScope` (Environment / Cluster / Replica), declared on system vars and dyncfg `Config`s and carried through to the synced system vars. * The size-family taxonomy: `ReplicaAllocation::family` with a size-map `family` field and a `cc`/`legacy` fallback for unset sizes. * The compute controller's per-replica dyncfg override layer (`update_replica_dyncfg_overrides`) and per-replica command specialization, unused until the adapter wires it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
antiguru
force-pushed
the
claude/scoped-flags-1-foundation
branch
from
d822816 to
620b77f
Compare
aljoscha
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
First of a three-PR stack splitting #36959 (scoped feature flags) for review:
1/3 (this) → 2/3 #37080 → 3/3 #36959. Design:
doc/developer/design/20260609_scoped_feature_flags.md (#36947).
This PR is the additive foundation: it introduces the vocabulary the later PRs
build on, with no behavior change on its own.
Description
ParameterScope(Environment/Cluster/Replica), declared on systemvars and dyncfg
Configs and carried through to the synced system vars. Thedeclaration is the single source of truth for which contexts get evaluated.
ReplicaAllocation::familyplus a size-mapfamilyfield, with a
cc/legacyfallback for sizes that don't set one.(
update_replica_dyncfg_overrides+ per-replica command specialization),inert until the adapter wires it in 3/3.
Nothing consumes the scope or the override layer yet, so this is a no-op.
Verification
test_replica_allocation_familycovers the size→family fallback; the rest isexercised by the later PRs in the stack.