sql-227: Fix statement-logging throttling when sample rate is changed#36892
Open
SangJunBak wants to merge 2 commits into
Open
sql-227: Fix statement-logging throttling when sample rate is changed#36892SangJunBak wants to merge 2 commits into
SangJunBak wants to merge 2 commits into
Conversation
SangJunBak
changed the title
…statement execution events In the frontend peek, we mutate mark a prepared statement as logged before the throttling check. Whileas in the original coordinator path, we wait until after. This causes a bug where if we initially throttled a statement, subsequent non-throttled executions will cause a prepared statement to never be logged in mz_prepared_statement_history
We mirror the behavior in the old coordinator statement logging where we mark it as logged after the throttle check
SangJunBak
force-pushed
the
jun/sql-227
branch
2 times, most recently
from
db37a9c to
cad37ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commit messages for details
Motivation
Fixes sql-227
etc.