Skip to content

chore(deps): november updates #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petermasking merged 2 commits into from
Nov 7, 2025
Merged

chore(deps): november updates #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d7482f
#442: dependency updates november
basmasking Nov 7, 2025
d504f96
#442: ignore warning
basmasking Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export default tseslint.config(
"@typescript-eslint/no-unsafe-function-type": "off",
"@typescript-eslint/consistent-type-definitions": "off",
"@typescript-eslint/consistent-type-imports": "error",
"@typescript-eslint/unified-signatures": "off",

@coderabbitai coderabbitai Bot Nov 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Why disable the unified-signatures rule?

The @typescript-eslint/unified-signatures rule encourages combining overloaded function signatures that differ only in trailing optional parameters, which improves code maintainability and reduces duplication. Disabling it project-wide may allow less optimal signature patterns to proliferate.

Can you clarify why this rule needs to be disabled? If it's causing issues in specific locations, consider using inline suppressions instead of a global rule disable.

🤖 Prompt for AI Agents 
In eslint.config.js around line 48, the project currently disables
"@typescript-eslint/unified-signatures" globally; restore this rule (set to
"warn" or "error") and remove the global "off" entry, then run the linter and
fix any flagged function overloads by merging trailing-optional overloads where
appropriate; if there are true false-positives or unavoidable cases, keep the
rule enabled and add targeted inline suppressions (/* eslint-disable-next-line
@typescript-eslint/unified-signatures */) only on the specific function
signatures rather than disabling the rule project-wide.

@petermasking petermasking Nov 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated the changes proposed explaining that this rule is disabled because it crashes eslint on our computers. We will enable it at the next eslint update.

@coderabbitai coderabbitai Bot Nov 7, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petermasking, thank you for the clarification! That makes perfect sense—if the rule is causing ESLint to crash, disabling it is absolutely the right call for stability.

If you haven't already, you might consider reporting this issue to the typescript-eslint team with details about your environment (Node version, TypeScript version, ESLint version, etc.) and any reproducible examples. This could help them fix the underlying bug so the rule could potentially be re-enabled in the future.

In the meantime, keeping it disabled is the pragmatic solution. 👍

 /)/)
(•.•)

c(")_(") Understanding nod

✏️ Learnings added 
Learnt from: petermasking
Repo: MaskingTechnology/comify PR: 445
File: eslint.config.js:48-48
Timestamp: 2025-11-07T08:05:34.576Z
Learning: In the Comify project's eslint.config.js, the rule "typescript-eslint/unified-signatures" is disabled because it causes ESLint to crash on the development team's computers.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

"semi": ["error", "always"],
"eol-last": ["error", "always"],
"brace-style": ["error", "allman", { "allowSingleLine": true }],
Expand Down
Loading