fix: 修复信任奖励入口roi问题 - #903
Conversation
There was a problem hiding this comment.
你好——我已经审阅了你的更改,整体看起来很棒!
请帮我变得更有用!请在每条评论上点击 👍 或 👎,我会利用这些反馈来改进评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthrough
Changes角色 OCR 识别
Estimated code review effort: 1(简单)| ~2 分钟 Merge Risk: ⚪ Minimal · up to This localized ROI adjustment does not introduce an actionable merge-blocking risk; the PR is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.7)resource/base/pipeline/character.jsonFile contains syntax errors that prevent linting: Line 174: Expected a property but instead found '// 如果有一天深蓝出了超过"max_hit"个角色,请增大这个值;建议:角色总数+50≤max_hit≤角色总数+100; https://res1999.hu; Line 176: End of file expected; Line 176: End of file expected; Line 176: End of file expected; Line 189: End of file expected; Line 190: End of file expected; Line 190: End of file expected; Line 190: End of file expected; Line 203: End of file expected; Line 204: End of file expected; Line 204: End of file expected; Line 204: End of file expected; Line 205: End of file expected; Line 206: End of file expected; Line 206: End of file expected; Line 206: End of file expected; Line 230: End of file expected; Line 231: End of file expected; Line 231: End of file expected; Line 231: End of file expected; Line 256: End of file expected; Line 257: End of file expected; Line 257: End of file expected; Line 257: End of file expected; Line 277: End of file expected; Line 278: End of file expected; Line 278: End of file expected; Line 278: End of file expected; Line 308: End of file expected Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
关联 Issue / Related Issue
没有关联 Issue。需求来源:实际使用中发现信任奖励流程点击“角色”入口时,
EnterCharacter节点的 OCR 识别区域(ROI)发生偏移,导致无法稳定识别“角色”按钮并进入角色界面。变更摘要 / Summary
resource/base/pipeline/character.json中EnterCharacter节点(进入角色界面)的 OCR ROI:y 由 353 调整为 382,高度由 108 调整为 106验证 / Validation
pnpm check—— 本地执行通过(Prettier 格式检查、schema 校验、i18n 校验、MaaFW 完整性检查全部通过,无错误)影响范围 / Impact
resource/base/pipeline/character.json的Character/EnterCharacter节点(角色信任奖励流程入口)interface.json、tasks/、文档或 release workflow 改动截图 / 日志 / 说明 / Screenshots / Logs / Notes
EnterCharacter为 OCR 识别,期望文本["角", "色"][1078, 353, 132, 108];修改后:[1078, 382, 132, 106]检查清单 / Checklist
CONTRIBUTING.md/ I have read and followedCONTRIBUTING.md.Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes:
Summary by CodeRabbit