fix: remove unresolved SessionLedger merge markers - #396
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:M
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummaryThis PR removes stale merge-conflict markers from viewer bundle loading, replay breadth assertions, and cross-language parity documentation. The viewer preserves async corpus loading and selection behavior. Corpus-loading errors now appear across all viewer tabs. Session metadata and structured intent data remain in bundles. Must FixNo blocking issues found. Should FixNo non-blocking issues found. ConsiderFull workspace formatting remains blocked by a pre-existing missing file on the base branch. Approve / Request ChangesApprove. The changes are focused and preserve existing behavior. Validation includes formatting checks, WalkthroughThe viewer centralizes session-to-bundle conversion, adds context and goal metadata, and tracks corpus loading errors. Cross-language parity documentation now covers three adapters and optional runtimes. Replay breadth tests remove conflict artifacts without changing behavior. ChangesViewer bundle and corpus flow
Cross-language parity documentation
Replay breadth test cleanup
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/sl-viewer/src/app.rs (1)
228-256: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winFix the toolchain and Dioxus version in this PR.
sl-viewerdeclaresdioxus = "0.7", which conflicts with the guideline that the viewer crate uses Dioxus 0.6. The pinned toolchain ischannel = "1.96.0", while the workspace policy requires Rust 1.85; align the toolchain or update the policy as part of this change.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/sl-viewer/src/app.rs` around lines 228 - 256, Update the sl-viewer Dioxus dependency to the workspace-required 0.6 version and align the pinned Rust toolchain from 1.96.0 with the required Rust 1.85 policy; if the project intentionally needs 1.96.0 instead, update the workspace policy consistently.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@crates/sl-viewer/src/app.rs`:
- Around line 228-256: Update the sl-viewer Dioxus dependency to the
workspace-required 0.6 version and align the pinned Rust toolchain from 1.96.0
with the required Rust 1.85 policy; if the project intentionally needs 1.96.0
instead, update the workspace policy consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8ddebba4-8e61-48c8-ba08-38d2ba7dbc55
📒 Files selected for processing (3)
crates/sl-viewer/src/app.rsdocs/ops/cross-language-parity.mdtests/replay_breadth.rs
💤 Files with no reviewable changes (1)
- tests/replay_breadth.rs
📜 Review details
⏰ Context from checks skipped due to timeout. (26)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: sl-daemon · locked offline build
- GitHub Check: race smoke + channel/cancel model · windows-latest
- GitHub Check: race smoke + channel/cancel model · macos-latest
- GitHub Check: jemalloc hard · SelfCheck
- GitHub Check: jemalloc default-on · windows default build
- GitHub Check: jemalloc default-on · unix default build
- GitHub Check: load macro gate · macro routes smoke
- GitHub Check: prepare
- GitHub Check: session-ledger build · macos-latest
- GitHub Check: browser e2e · axe · responsive · visual
- GitHub Check: sl-daemon build · windows-latest
- GitHub Check: sl-viewer macOS app · artifact
- GitHub Check: session-ledger build · windows-latest
- GitHub Check: exotic check · aarch64-unknown-linux-gnu
- GitHub Check: soft loom · daemon broadcast
- GitHub Check: fuzz blocking · SelfCheck
- GitHub Check: soft loom · loom_model core
- GitHub Check: fuzz blocking · sustained 30s
- GitHub Check: loom permutation · core models
- GitHub Check: visual contract · WCAG AA
- GitHub Check: loom permutation · daemon mpsc
- GitHub Check: pipeline perf regression gate
- GitHub Check: Summary
- GitHub Check: prepare
- GitHub Check: prepare
⚠️ CI failures not shown inline (2)
GitHub Actions: Trunk Check / 0_Lint & Format.txt: fix: remove unresolved SessionLedger merge markers
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
GitHub Actions: Trunk Check / Lint & Format: fix: remove unresolved SessionLedger merge markers
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{rs,toml}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{rs,toml}: Use the Rust toolchain pinned inrust-toolchain.toml; the workspace MSRV is Rust 1.85.
Validate Rust workspace changes with the prescribed locked build, all-features test suite, Clippy, and rustfmt checks where applicable.
Files:
crates/sl-viewer/src/app.rs
**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
Fix Clippy warnings; do not add
#[allow]unless it includes a tracking-issue comment.
Files:
crates/sl-viewer/src/app.rs
crates/sl-viewer/**/*.{rs,toml}
📄 CodeRabbit inference engine (AGENTS.md)
crates/sl-viewer/**/*.{rs,toml}: Thesl-viewercrate uses Dioxus 0.6; use the Dioxus CLI/toolchain for desktop development and bundling.
Usecargo check -p sl-vieweras the fast inner-loop check for viewer changes.
Files:
crates/sl-viewer/src/app.rs
crates/sl-viewer/**/*
📄 CodeRabbit inference engine (AGENTS.md)
When packaging the macOS viewer, account for the documented Electrobun/Dioxus code-signing requirements.
Files:
crates/sl-viewer/src/app.rs
🔇 Additional comments (4)
crates/sl-viewer/src/app.rs (1)
27-28: LGTM!Also applies to: 154-189, 403-405, 882-882, 962-1004
docs/ops/cross-language-parity.md (3)
90-107: LGTM!
119-138: LGTM!
139-139: 📐 Maintainability & Code QualityClarify the blocking CI contract for cross-language parity.
The workflow does run
script/cross-language-parity-check.ps1onpull_requestandpushwith a non-skipped SelfCheck job, but the documented claim of "(blocking)" may be stronger than the repo can prove unlesseval-compression/cross-language parity SelfCheckis separately configured as a required check formain.
![codeant-ai[bot]](https://avatars.github.com/in/646884?s=60&v=4){kind=small}
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/sl-viewer/src/app.rs (1)
403-405: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winPass loading state into TimelineView so the empty text cannot hide loading.
TimelineViewonly receivesbundles, and its empty branch renders"No bundles to display"without distinguishing a corpus that is still loading. Pass the loading/error state explicitly, or show a loading state that makes this path wait for the corpus to finish loading before switching to the empty-corpus message.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/sl-viewer/src/app.rs` around lines 403 - 405, Update the Tab::Timeline construction of TimelineView to provide the corpus loading/error state alongside bundles, and update TimelineView’s empty-state handling to render loading or error feedback before “No bundles to display.” Preserve the empty-corpus message only after loading completes successfully with no bundles.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/sl-viewer/src/app.rs`:
- Around line 881-886: Update the Bundles tab rendering around Tab::Bundles and
BundlesTab so the corpus error is displayed only by the global
corpus-error-banner. Suppress the local ErrorState for the same corpus_error
value while preserving any contextual recovery controls that BundlesTab
requires.
---
Outside diff comments:
In `@crates/sl-viewer/src/app.rs`:
- Around line 403-405: Update the Tab::Timeline construction of TimelineView to
provide the corpus loading/error state alongside bundles, and update
TimelineView’s empty-state handling to render loading or error feedback before
“No bundles to display.” Preserve the empty-corpus message only after loading
completes successfully with no bundles.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f5cbe6d6-aa7d-47de-baaa-3341a7add616
📒 Files selected for processing (1)
crates/sl-viewer/src/app.rs
📜 Review details
⏰ Context from checks skipped due to timeout. (40)
- GitHub Check: Rust
- GitHub Check: sl-daemon · repository builder image offline build / sl-daemon · repository builder image offline build
- GitHub Check: hermetic · reusable workflow provenance (soft)
- GitHub Check: fuzz blocking · sustained 30s
- GitHub Check: Kilo Code Review
- GitHub Check: jemalloc hard · feature build
- GitHub Check: loom permutation · SelfCheck
- GitHub Check: loom permutation · daemon pipeline
- GitHub Check: loom permutation · daemon shutdown
- GitHub Check: loom permutation · daemon mpsc
- GitHub Check: loom permutation · core models
- GitHub Check: miri permutation · race_model
- GitHub Check: loom permutation · daemon broadcast
- GitHub Check: daemon graph hard · tokio graph
- GitHub Check: soft fuzz · SelfCheck
- GitHub Check: visual contract · WCAG AA
- GitHub Check: prepare
- GitHub Check: soft loom · daemon broadcast
- GitHub Check: jemalloc default-on · unix default build
- GitHub Check: shuttle permutation · cargo test shuttle_permutation
- GitHub Check: browser e2e · axe · responsive · visual
- GitHub Check: soft loom · loom_model core
- GitHub Check: race smoke + channel/cancel model · windows-latest
- GitHub Check: update check hard · sl-daemon tests
- GitHub Check: race smoke + channel/cancel model · macos-latest
- GitHub Check: pipeline perf regression gate
- GitHub Check: sl-daemon build · windows-latest
- GitHub Check: sl-daemon build · macos-latest
- GitHub Check: exotic check · aarch64-unknown-linux-gnu
- GitHub Check: session-ledger build · macos-latest
- GitHub Check: jemalloc default-on · windows default build
- GitHub Check: alloc profile hard · dhat smoke
- GitHub Check: session-ledger build · windows-latest
- GitHub Check: exotic check · x86_64-unknown-linux-musl
- GitHub Check: sl-viewer macOS app · artifact
- GitHub Check: tsan permutation · race_model
- GitHub Check: sl-viewer help · unit tests
- GitHub Check: Summary
- GitHub Check: prepare
- GitHub Check: browser e2e · axe · responsive · visual
⚠️ CI failures not shown inline (6)
GitHub Actions: Trunk Check / Lint & Format: fix: remove unresolved SessionLedger merge markers
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
GitHub Actions: Trunk Check / 0_Lint & Format.txt: fix: remove unresolved SessionLedger merge markers
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
GitHub Actions: signing hard / 0_signing hard · SelfCheck.txt: fix: remove unresolved SessionLedger merge markers
Conclusion: failure
##[group]Run ./scripts/signing-readiness-check.ps1 -SelfCheck
�[36;1m./scripts/signing-readiness-check.ps1 -SelfCheck�[0m
shell: /usr/bin/pwsh -command ". '{0}'"
##[endgroup]
Platform signing readiness check (C11 L112 hard evidence)
Mode: SelfCheck (ADR + release.yml unsigned anchors + blocking hard CI; no secrets / no network)
ADR 0003 anchors:
[PASS] ADR deferral title
[PASS] ADR portable SHA256SUMS trust path
[PASS] ADR Authenticode deferral
[PASS] ADR notarization deferral
[PASS] ADR reconsider triggers
[PASS] ADR cross-link to signing readiness checklist
Signing readiness checklist anchors:
[PASS] checklist heading
[PASS] unsigned current state section
[PASS] unsigned MSI artifact naming
[PASS] unsigned PKG artifact naming
[PASS] SelfCheck script reference
[PASS] SelfCheck gate marked done
[PASS] soft vs hard gates matrix section
[PASS] blocking hard CI gate marked done
[PASS] signing-hard workflow path documented
[PASS] signing_hard test wrapper documented
[PASS] unpaid Apple credential gate
[PASS] unpaid Windows credential gate
[PASS] signed clean-host smoke unpaid gate
[PASS] ADR 0001 auto-update unpaid gate
[PASS] no fake secrets policy
[PASS] no false platform signing claim
release.yml unsigned path anchors:
[PASS] release.yml deferral header comment
[PASS] unsigned Windows MSI packaging step
[PASS] unsigned macOS PKG packaging step
[PASS] package-msi.ps1 invocation
[PASS] smoke-windows job
[PASS] smoke-macos-pkg job
[PASS] MSI silent install smoke anchor
[PASS] ADR 0003 reference in release workflow
[PASS] release signing-readiness job
[PASS] release invokes signing-readiness SelfCheck
[PASS] release.yml smoke + signing-readiness job definitions present
signing-hard workflow blocking-gate anchors:
[PASS] hard workflow has no continue-on-error
[PASS] hard workflow triggers on pull_request
[PASS] hard workflow runs signing-readiness-check....
GitHub Actions: signing hard / signing hard · SelfCheck: fix: remove unresolved SessionLedger merge markers
Conclusion: failure
##[group]Run ./scripts/signing-readiness-check.ps1 -SelfCheck
�[36;1m./scripts/signing-readiness-check.ps1 -SelfCheck�[0m
shell: /usr/bin/pwsh -command ". '{0}'"
##[endgroup]
Platform signing readiness check (C11 L112 hard evidence)
Mode: SelfCheck (ADR + release.yml unsigned anchors + blocking hard CI; no secrets / no network)
ADR 0003 anchors:
[PASS] ADR deferral title
[PASS] ADR portable SHA256SUMS trust path
[PASS] ADR Authenticode deferral
[PASS] ADR notarization deferral
[PASS] ADR reconsider triggers
[PASS] ADR cross-link to signing readiness checklist
Signing readiness checklist anchors:
[PASS] checklist heading
[PASS] unsigned current state section
[PASS] unsigned MSI artifact naming
[PASS] unsigned PKG artifact naming
[PASS] SelfCheck script reference
[PASS] SelfCheck gate marked done
[PASS] soft vs hard gates matrix section
[PASS] blocking hard CI gate marked done
[PASS] signing-hard workflow path documented
[PASS] signing_hard test wrapper documented
[PASS] unpaid Apple credential gate
[PASS] unpaid Windows credential gate
[PASS] signed clean-host smoke unpaid gate
[PASS] ADR 0001 auto-update unpaid gate
[PASS] no fake secrets policy
[PASS] no false platform signing claim
release.yml unsigned path anchors:
[PASS] release.yml deferral header comment
[PASS] unsigned Windows MSI packaging step
[PASS] unsigned macOS PKG packaging step
[PASS] package-msi.ps1 invocation
[PASS] smoke-windows job
[PASS] smoke-macos-pkg job
[PASS] MSI silent install smoke anchor
[PASS] ADR 0003 reference in release workflow
[PASS] release signing-readiness job
[PASS] release invokes signing-readiness SelfCheck
[PASS] release.yml smoke + signing-readiness job definitions present
signing-hard workflow blocking-gate anchors:
[PASS] hard workflow has no continue-on-error
[PASS] hard workflow triggers on pull_request
[PASS] hard workflow runs signing-readiness-check....
GitHub Actions: rootless matrix / rootless-only matrix · SelfCheck: fix: remove unresolved SessionLedger merge markers
Conclusion: failure
##[group]Run ./scripts/rootless-matrix-check.ps1 -SelfCheck
�[36;1m./scripts/rootless-matrix-check.ps1 -SelfCheck�[0m
shell: /usr/bin/pwsh -command ". '{0}'"
##[endgroup]
Rootless-only OCI runner matrix scaffold check (C04 L40)
Mode: SelfCheck (docs + workflow + security/ci anchors; no OCI build / no network)
Rootless-only runner matrix doc anchors:
[PASS] rootless-only matrix section heading
[PASS] SelfCheck script reference
[PASS] SelfCheck gate marked done
[PASS] blocking workflow gate marked done
[PASS] rootless-matrix workflow path documented
[PASS] cargo test wrapper documented
[PASS] runner capability matrix documented
[PASS] live rootless runner matrix remains unpaid
[PASS] OCI build/smoke in matrix remains unpaid
[PASS] no false OCI build claim
[PASS] no false live-runner enforcement claim
rootless-matrix workflow blocking-gate anchors:
[PASS] workflow has no continue-on-error
[PASS] workflow triggers on pull_request
[PASS] workflow runs rootless-matrix-check.ps1
security.yml / ci.yml cross-reference anchors:
[PASS] security.yml references rootless-matrix workflow
[PASS] security.yml references rootless-matrix SelfCheck script
[FAIL] ci.yml references rootless-matrix workflow
�[31;1mException: �[0m/home/runner/work/SessionLedger/SessionLedger/scripts/rootless-matrix-check.ps1:65�[0m
�[31;1m�[0m�[36;1mLine |�[0m
�[31;1m�[0m�[36;1m�[36;1m 65 | �[0m �[36;1mthrow "$Context missing required anchor: '$Needle'"�[0m
�[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
�[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m | �[31;1m.github/workflows/ci.yml missing required anchor: 'rootless-matrix.yml'�[0m
##[error]Process completed with exit code 1.
GitHub Actions: rootless matrix / 0_rootless-only matrix · SelfCheck.txt: fix: remove unresolved SessionLedger merge markers
Conclusion: failure
##[group]Run ./scripts/rootless-matrix-check.ps1 -SelfCheck
�[36;1m./scripts/rootless-matrix-check.ps1 -SelfCheck�[0m
shell: /usr/bin/pwsh -command ". '{0}'"
##[endgroup]
Rootless-only OCI runner matrix scaffold check (C04 L40)
Mode: SelfCheck (docs + workflow + security/ci anchors; no OCI build / no network)
Rootless-only runner matrix doc anchors:
[PASS] rootless-only matrix section heading
[PASS] SelfCheck script reference
[PASS] SelfCheck gate marked done
[PASS] blocking workflow gate marked done
[PASS] rootless-matrix workflow path documented
[PASS] cargo test wrapper documented
[PASS] runner capability matrix documented
[PASS] live rootless runner matrix remains unpaid
[PASS] OCI build/smoke in matrix remains unpaid
[PASS] no false OCI build claim
[PASS] no false live-runner enforcement claim
rootless-matrix workflow blocking-gate anchors:
[PASS] workflow has no continue-on-error
[PASS] workflow triggers on pull_request
[PASS] workflow runs rootless-matrix-check.ps1
security.yml / ci.yml cross-reference anchors:
[PASS] security.yml references rootless-matrix workflow
[PASS] security.yml references rootless-matrix SelfCheck script
[FAIL] ci.yml references rootless-matrix workflow
�[31;1mException: �[0m/home/runner/work/SessionLedger/SessionLedger/scripts/rootless-matrix-check.ps1:65�[0m
�[31;1m�[0m�[36;1mLine |�[0m
�[31;1m�[0m�[36;1m�[36;1m 65 | �[0m �[36;1mthrow "$Context missing required anchor: '$Needle'"�[0m
�[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
�[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m | �[31;1m.github/workflows/ci.yml missing required anchor: 'rootless-matrix.yml'�[0m
##[error]Process completed with exit code 1.
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{rs,toml}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{rs,toml}: Use the Rust toolchain pinned inrust-toolchain.toml; the workspace MSRV is Rust 1.85.
Validate Rust workspace changes with the prescribed locked build, all-features test suite, Clippy, and rustfmt checks where applicable.
Files:
crates/sl-viewer/src/app.rs
**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
Fix Clippy warnings; do not add
#[allow]unless it includes a tracking-issue comment.
Files:
crates/sl-viewer/src/app.rs
crates/sl-viewer/**/*.{rs,toml}
📄 CodeRabbit inference engine (AGENTS.md)
crates/sl-viewer/**/*.{rs,toml}: Thesl-viewercrate uses Dioxus 0.6; use the Dioxus CLI/toolchain for desktop development and bundling.
Usecargo check -p sl-vieweras the fast inner-loop check for viewer changes.
Files:
crates/sl-viewer/src/app.rs
crates/sl-viewer/**/*
📄 CodeRabbit inference engine (AGENTS.md)
When packaging the macOS viewer, account for the documented Electrobun/Dioxus code-signing requirements.
Files:
crates/sl-viewer/src/app.rs
🔇 Additional comments (4)
crates/sl-viewer/src/app.rs (4)
28-28: LGTM!Also applies to: 168-171
154-165: 🗄️ Data Integrity & IntegrationNo change needed. The Context bundle is always rendered, and empty context values are handled by the detail view and OKF translation.
173-189: 🗄️ Data Integrity & IntegrationNo change needed. Summary and detail consumers read
goal: Option<String>and render a safe fallback when the intent goal is absent.
228-256: 📐 Maintainability & Code QualityRun the required Dioxus validation checks.
The manifest declares Dioxus 0.7 for
crates/sl-viewer, and that version is pinned for runtime behavior. Run the prescribed viewer/workspace checks with the locked toolchain before relying on this path.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by step-3.7-flash · Input: 205.5K · Output: 50.2K · Cached: 4.4M |
![kilo-code-bot[bot]](https://avatars.github.com/in/2193792?s=60&v=4){kind=small}
…rs-20260802' into fix/sessionledger-conflict-markers-20260802
|
@coderabbitai review |
✅ Action performedReview finished.
|
User description
Summary
Provenance
Validation
rustfmt --edition 2021 --check crates/sl-viewer/src/app.rs tests/replay_breadth.rsgit diff --checkcargo fmt --all -- --checkremains blocked by pre-existing missingcrates/sl-viewer/src/corpus_loader/web_exports.rson base; no unrelated files changedCodeAnt-AI Description
Remove unresolved merge markers and restore consistent viewer, test, and parity documentation behavior
What Changed
Impact
✅ Viewer builds without merge-marker errors✅ Clearer corpus loading and failure states✅ Reliable replay and parity validation💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.