fix(tests): make replay self-checks portable

[KooshaPari]

Summary

• preserve the remaining dirty SessionLedger replay and self-check tests
• make PowerShell self-checks portable on non-Windows hosts
• retain loom formatting and fixture assertions

Validation

• source changes committed and pushed
• hosted checks should validate against the icon-bundle base

No files or history were deleted or rewritten.

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3eca760f-f769-454e-832f-0eccfb26415c

📥 Commits

Reviewing files that changed from the base of the PR and between b9e2630 and 75f9220.

📒 Files selected for processing (4)

• tests/alertmanager_soft.rs
• tests/alloc_profile.rs
• tests/loom_http_sse_soak.rs
• tests/replay_breadth.rs

📜 Recent review details

⏰ Context from checks skipped due to timeout. (35)

• GitHub Check: semgrep-cloud-platform/scan
• GitHub Check: sl-daemon · repository builder image offline build / sl-daemon · repository builder image offline build
• GitHub Check: fuzz smoke (10 seconds)
• GitHub Check: coverage (85% gate)
• GitHub Check: reproducible build · sl-daemon
• GitHub Check: clean-host smoke · Windows unsigned portable install
• GitHub Check: jemalloc default-on · windows default build
• GitHub Check: sandbox boundary smoke
• GitHub Check: rootless-only matrix scaffold
• GitHub Check: SLSA protected-environment SelfCheck
• GitHub Check: browser e2e · axe · responsive · visual
• GitHub Check: visual contract · WCAG AA
• GitHub Check: fuzz blocking · sustained 30s
• GitHub Check: alloc profile hard · dhat smoke
• GitHub Check: update check hard · sl-daemon tests
• GitHub Check: tsan permutation · race_model
• GitHub Check: soft loom · daemon broadcast
• GitHub Check: jemalloc hard · feature build
• GitHub Check: load macro gate · macro routes smoke
• GitHub Check: update check hard · root SelfCheck wrapper
• GitHub Check: miri permutation · race_model
• GitHub Check: race smoke + channel/cancel model · windows-latest
• GitHub Check: sl-daemon build · windows-latest
• GitHub Check: race smoke + channel/cancel model · macos-latest
• GitHub Check: sl-viewer macOS app · artifact
• GitHub Check: session-ledger build · windows-latest
• GitHub Check: loom permutation · daemon pipeline
• GitHub Check: loom permutation · daemon broadcast
• GitHub Check: loom permutation · hermetic wrappers
• GitHub Check: loom permutation · core models
• GitHub Check: loom permutation · daemon mpsc
• GitHub Check: loom permutation · daemon shutdown
• GitHub Check: Summary
• GitHub Check: prepare
• GitHub Check: browser e2e · axe · responsive · visual

⚠️ CI failures not shown inline (2)

GitHub Check: Summary: The current Mergify configuration is invalid

Conclusion: failure

View job details

* Invalid condition 'author=dependabot[bot] | renovate[bot]' @ root → pull_request_rules → item 1 → conditions → item 0 → author=dependabot[bot] | renovate[bot]
```
Invalid GitHub login
```
* Invalid condition 'author=trunk-io[bot] | mergify[bot] | github-actions[bot]' @ root → pull_request_rules → item 2 → conditions → item 0 → author=trunk-io[bot] | mergify[bot] | github-actions[bot]
```
Invalid GitHub login
```
* Invalid condition 'age>=30d' @ root → pull_request_rules → item 8 → conditions → item 2 → age>=30d
```
Invalid attribute
```
* Extra inputs are not permitted @ root → pull_request_rules → item 0 → actions → post_merge
* Extra inputs are not permitted @ root → pull_request_rules → item 1 → actions → post_merge
* Extra inputs are not permitted @ root → pull_request_rules → item 3 → actions → request_reviews → github_accounts

---

GitHub Check: Mergify Merge Queue: The current Mergify configuration is invalid

Conclusion: failure

View job details

* Invalid condition 'author=dependabot[bot] | renovate[bot]' @ root → pull_request_rules → item 1 → conditions → item 0 → author=dependabot[bot] | renovate[bot]
```
Invalid GitHub login
```
* Invalid condition 'author=trunk-io[bot] | mergify[bot] | github-actions[bot]' @ root → pull_request_rules → item 2 → conditions → item 0 → author=trunk-io[bot] | mergify[bot] | github-actions[bot]
```
Invalid GitHub login
```
* Invalid condition 'age>=30d' @ root → pull_request_rules → item 8 → conditions → item 2 → age>=30d
```
Invalid attribute
```
* Extra inputs are not permitted @ root → pull_request_rules → item 0 → actions → post_merge
* Extra inputs are not permitted @ root → pull_request_rules → item 1 → actions → post_merge
* Extra inputs are not permitted @ root → pull_request_rules → item 3 → actions → request_reviews → github_accounts

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{rs,toml}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{rs,toml}: Use the Rust toolchain pinned in rust-toolchain.toml; the workspace MSRV is Rust 1.85.
Validate Rust workspace changes with the prescribed locked build, all-features test suite, Clippy, and rustfmt checks where applicable.

Files:

• tests/alloc_profile.rs
• tests/alertmanager_soft.rs
• tests/loom_http_sse_soak.rs
• tests/replay_breadth.rs

**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

Fix Clippy warnings; do not add #[allow] unless it includes a tracking-issue comment.

Files:

• tests/alloc_profile.rs
• tests/alertmanager_soft.rs
• tests/loom_http_sse_soak.rs
• tests/replay_breadth.rs

🔇 Additional comments (3)

tests/loom_http_sse_soak.rs (1)

168-174: LGTM!

Also applies to: 241-245, 268-280

tests/replay_breadth.rs (1)

38-38: LGTM!

Also applies to: 122-124, 126-136, 138-144

tests/alertmanager_soft.rs (1)

13-50: 📐 Maintainability & Code Quality

Verify both platform paths with the required Rust checks.

• tests/alertmanager_soft.rs#L13-L50: confirm the Windows pwsh execution path and non-Windows evidence path both pass.
• tests/alloc_profile.rs#L60-L102: confirm the PowerShell path and unavailable-pwsh fallback pass.

Please validate with the rust-toolchain.toml toolchain using the prescribed locked build, all-features tests, Clippy, and rustfmt checks. As per coding guidelines, “Use the Rust toolchain pinned in rust-toolchain.toml; the workspace MSRV is Rust 1.85” and validate applicable Rust changes with locked build, all-features tests, Clippy, and rustfmt.

Source: Coding guidelines

---

📝 Walkthrough

Summary

Updates replay and self-check tests to preserve fixture and formatting coverage, and improves portability of PowerShell-based checks on non-Windows hosts.

Must Fix

None identified.

Should Fix

None.

Consider

The changes are limited to test portability, assertion preservation, and formatting; no public APIs, production code, dependencies, or history are changed.

Approve / Request Changes

Approve.

Walkthrough

The changes make Alertmanager and allocation-profile self-check tests portable across operating systems, while reformatting loom and replay-breadth tests without changing their assertions or control flow.

Changes

Test portability and maintenance

Layer / File(s)	Summary
Portable self-check execution tests/alertmanager_soft.rs, tests/alloc_profile.rs	Alertmanager uses Windows-specific execution and non-Windows documentation checks; allocation-profile tests use a JSON fallback when PowerShell cannot be spawned.
Test assertion and fixture formatting tests/loom_http_sse_soak.rs, tests/replay_breadth.rs	Existing loom control flow, assertions, fixture paths, generator checks, and documentation checks are reformatted without changing their semantics.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• KooshaPari/SessionLedger#250: Introduces the allocation-profile self-check that this change makes more portable.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: making test self-checks portable across hosts.
Description check	✅ Passed	The description is directly related to the changeset and summarizes the portability and test-preservation work.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Fix failing CI checks

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/replay-portable-self-checks

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch fix/replay-portable-self-checks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}