feat: Home Assistant: Discover temperature sensor for thermostats - #30804
Merged
Conversation
Refactor localTemperatureSensor assignment for better readability.
Contributor
Author
|
This probably deserves a unit test. There's also a small number of devices that already do expose |
Owner
|
Could you extend ? |
Removed duplicate unique_id from the payload in the test.
Contributor
Author
|
@Koenkk AFAIK, there's no mock device in tests that already exposes Currently, my test only covers the most common case, i.e. discover Is this good enough? |
Owner
|
yes, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the HA folks, it's current best practice to expose/discover an additional temperature sensor for each thermostat because the
current_temperatureattribute ofclimateentities is not kept for long-term statistics.By implementing this using the
homeassistant.tsextension, we avoid exposing fake sensors to other ecosystems while still improving the UX for HA users. 馃槉Fixes #29686