Migrate LSP out of React#12452
Open
franknoirot wants to merge 7 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
franknoirot
force-pushed
the
franknoirot/migrate-lsp-out-of-react
branch
from
July 14, 2026 23:07
c1e2042 to
129df23
Compare
franknoirot
marked this pull request as ready for review
July 14, 2026 23:34
franknoirot
force-pushed
the
franknoirot/migrate-lsp-out-of-react
branch
from
July 15, 2026 15:08
129df23 to
6b77e1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our LSP has been mounted via React since the beginning, but it hasn't needed to be since #9448. This refactor PR does the following:
/src/lang/lsp/src/lang/lsp/service.ts)LspProvider, instead attaching the LSP extension immediately to KclManager (this should speed up LSP connection times)This is a pretty important subsystem to be moving around, so it's done in step-by-step commits that you should be able to follow along with to get a sense of how we go from
to