Add Warnings As Errors#482
Merged
TomAtkinsonArm merged 5 commits intoJul 8, 2022
Merged
Conversation
TomAtkinsonArm
requested review from
SaschaWillems,
asuessenbach,
gary-sweet and
gpx1000
July 7, 2022 09:59
Contributor
Author
|
@asuessenbach if this merges first I can fix the folder issue that you found in the other PR in a new PR |
SaschaWillems
approved these changes
Jul 8, 2022
SaschaWillems
left a comment
SaschaWillems
left a comment
Collaborator
There was a problem hiding this comment.
LGTM and compiles fine with Visual Studio 2019.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds warnings as errors.
Adds
vkb__register_componentto guarantee consistent library creation. Warnings are set at a target level which should make sure third party warnings are ignored. If this is not the case then we will need to create warning wrappers similar to the master branch.Fixes #478