[codex] Fix data parser cache leaks with attribution#736
Merged
ObservedObserver merged 3 commits intoJun 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@lru_cache()on data parser cached properties with per-instancecached_propertyin the final implementation.Root Cause
functools.lru_cachestores calls in the decorated function wrapper. For instance methods and properties, that cache key includesself, so parser instances are retained by the class-level cache after callers drop their references. Those parser instances keep their DataFrames alive, causing memory growth in long-running processes that parse many datasets.Notes
This PR carries forward the original work from #724, then adds a compatibility adjustment: the final implementation uses
cached_propertyinstead of storing athreading.Lockon parser instances, so parser pickling keeps working.Supersedes #735.
Fixes #723.
Validation
./venv/bin/python -m pytest tests/test_data_parsers.py -q./venv/bin/python -m pytest -q./venv/bin/python -m ruff check .