Skip to content

Remove QuartzImageIO#384

Merged
ViralBShah merged 2 commits into
masterfrom
vs/rm-quartzimageio
Mar 16, 2024
Merged

Remove QuartzImageIO#384
ViralBShah merged 2 commits into
masterfrom
vs/rm-quartzimageio

Conversation

@ViralBShah

Copy link
Copy Markdown
Member

As discussed in JuliaIO/QuartzImageIO.jl#77

@ViralBShah

Copy link
Copy Markdown
Member Author

Failures on nightly are not related to this PR. I think we should be able to merge.

@codecov

codecov Bot commented Mar 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (b7259eb) to head (5df2454).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          10       10           
  Lines         708      708           
=======================================
  Hits          649      649           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
ViralBShah merged commit 91661df into master Mar 16, 2024
@ViralBShah
ViralBShah deleted the vs/rm-quartzimageio branch March 16, 2024 13:34
@kimikage

kimikage commented May 16, 2024

Copy link
Copy Markdown

The registry table on documentation is not updated. https://juliaio.github.io/FileIO.jl/dev/registry/#Registry-table
Maybe it would be better to generate the table automatically or add something like doctest.

Also, "on all platforms with" is no longer useful at all. We do not have a "practical" mechanism to actively select libraries according to platform and that should be the reason for removing QuartzImageIO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants