Bot Names per team - #340
Merged
Joe91 merged 24 commits intoSep 26, 2024
Merged
Conversation
# Conflicts: # .github/CHANGELOG.md # ext/Shared/Registry/Registry.lua # mod.json
# Conflicts: # .github/CHANGELOG.md # ext/Server/Bot/BotMovement.lua # ext/Server/Bot/VehicleMovement.lua # ext/Shared/Registry/Registry.lua # mod.db # mod.json
# Conflicts: # ext/Shared/Registry/Registry.lua # mod.json
# Conflicts: # ext/Shared/Registry/Registry.lua # mod.json
# Conflicts: # ext/Shared/Registry/Registry.lua # mod.json
# Conflicts: # ext/Shared/Registry/Registry.lua # mod.json
…mes from the original list or to use names from 2 new lists per team :)
Owner
|
Wow, this really looks very good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the necessary changes to be able to select via configs if either we want to use the original random names or the new lists with names per team.
The branch started from the latest stable release tag 2.9.1 and was tested using it. Alongisde many other mods.
No crashes at all.
Only one minor defect detected is that if we change this setting on the fly it may be imperfect, some bots spawned before or just in the same time we were choosing this new option may stay alongside the new ones with the new set of names.
This doesn't seem to be breaking or causing any error, but the only clean way of doing it is to kill all the bots, and then change the starting spawn number manually. Or Kill and create exactly the amount of bots we want with the tool to spawn them by a particular number.