Skip to content

Fix bots getting stuck between the base and first capture point - #323

Merged
Joe91 merged 2 commits into
Joe91:devfrom
tagener-noisu:feature/navigation_fixes2
Jan 1, 2024
Merged

Fix bots getting stuck between the base and first capture point#323
Joe91 merged 2 commits into
Joe91:devfrom
tagener-noisu:feature/navigation_fixes2

Conversation

@tagener-noisu

Copy link
Copy Markdown
Collaborator

I'm not sure why there's this check, but it makes bot stuck between the base and the first objective, but this change fixes that.
Can you check if it's a correct fix?

@Joe91

Joe91 commented Dec 19, 2023

Copy link
Copy Markdown
Owner

Good point here, but I think we should not do it this way. This might solve some issues with some paths, but cause other issues with some other paths. I think Instead we should add some random-based behaviour in the section below. Maybe in the case of equal priority switch with a 70% change or something like that?

@tagener-noisu

Copy link
Copy Markdown
Collaborator Author

Yes. I noticed what was wrong this time. It all started with the previous fix I added. Since it had priority = 0, it didn't work sometimes. I reversed the previous commit and just bumped priorities on every branch by one. Looks good atm, but need some more testing. I'll play some more later.

@Firjens
Firjens requested a review from Joe91 December 26, 2023 19:51
@Firjens Firjens added enhancement Suggestion for a change to an existing feature Scope: bot behavior Suggestions for changing bot behaviors labels Dec 26, 2023
@Firjens

Firjens commented Dec 26, 2023

Copy link
Copy Markdown
Contributor

What is the difference between the old and new behavior with your change? Can you explain it a bit further?

@tagener-noisu

Copy link
Copy Markdown
Collaborator Author

I'm not sure what do you want to hear, it's a fix of the bot behaviour. There were some cases when the bots were getting stuck between two points and I fixed that. Well, I fixed it in the previous PR, but it didn't work as I exected in some cases, so this PR shoud fix it.

I tested it and it works good in my opinion.

@Joe91

Joe91 commented Dec 31, 2023

Copy link
Copy Markdown
Owner

Will try to merge it tomorrow. Sorry for the delay and thanks a lot for your contribution!

@Joe91
Joe91 merged commit 6cbc3d8 into Joe91:dev Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Suggestion for a change to an existing feature Scope: bot behavior Suggestions for changing bot behaviors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants